Skip to content

node-api: test passing NULL to napi_define_class - #47567

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
gabrielschulhof:pass-null-to-napi_define_class
Apr 26, 2023
Merged

node-api: test passing NULL to napi_define_class#47567
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
gabrielschulhof:pass-null-to-napi_define_class

Conversation

@gabrielschulhof

@gabrielschulhofgabrielschulhof commented Apr 15, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-bot

nodejs-github-bot commented Apr 15, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Apr 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51402/

This was referenced Apr 24, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51464/

mhdawson
mhdawson approved these changes Apr 25, 2023
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawsonmhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51466/

@github-actionsgithub-actionsBot mentioned this pull request Apr 26, 2023
Open
36 tasks
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 11f97d4 into nodejs:mainApr 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

Landed in 11f97d4

@github-actionsgithub-actionsBot mentioned this pull request Apr 27, 2023
Open
35 tasks
@toyobayashitoyobayashi mentioned this pull request Apr 27, 2023
Merged
@github-actionsgithub-actionsBot mentioned this pull request Apr 28, 2023
Open
29 tasks
@github-actionsgithub-actionsBot mentioned this pull request Apr 29, 2023
Open
32 tasks
This was referenced Apr 30, 2023
Open
Open
targos pushed a commit that referenced this pull request May 2, 2023
@gabrielschulhof@targos
node-api: test passing NULL to napi_define_class
4d02901
PR-URL: #47567
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targostargos mentioned this pull request May 2, 2023
Merged
@gabrielschulhof
gabrielschulhof deleted the pass-null-to-napi_define_class branch May 20, 2023 01:05
@gabrielschulhof
gabrielschulhof restored the pass-null-to-napi_define_class branch May 20, 2023 14:41
@gabrielschulhof
gabrielschulhof deleted the pass-null-to-napi_define_class branch June 3, 2023 18:10
@gabrielschulhof
gabrielschulhof restored the pass-null-to-napi_define_class branch June 5, 2023 02:21
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@gabrielschulhof@danielleadams
node-api: test passing NULL to napi_define_class
6735637
PR-URL: #47567
Reviewed-By: Michael Dawson <midawson@redhat.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@gabrielschulhof@MoLow
node-api: test passing NULL to napi_define_class
beaad7f
PR-URL: nodejs#47567
Reviewed-By: Michael Dawson <midawson@redhat.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
@gabrielschulhof
gabrielschulhof deleted the pass-null-to-napi_define_class branch December 30, 2024 19:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecaslegendecasAwaiting requested review from legendecas
1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.node-apiIssues and PRs related to the Node-API.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gabrielschulhof@nodejs-github-bot@mhdawson@lpinca