Uh oh!
There was an error while loading. Please reload this page.
test_runner: avoid reporting parents of failing tests in summary - #47579
Merged
Conversation
nodejs-github-bot
commented
Apr 16, 2023
Collaborator
Review requested:
|
MoLowforce-pushed
the
skip-subtest-failures
branch
from
April 16, 2023 09:36
5ba622b to
61856dcComparebenjamingr
approved these changes
Apr 17, 2023
nodejs-github-bot
commented
Apr 17, 2023
Collaborator
aduh95
approved these changes
Apr 17, 2023
aduh95
commented
Apr 17, 2023
Contributor
Is this
semver-major |
MoLow
commented
Apr 17, 2023
MemberAuthor
@aduh95 I think we agreed that reporters output is still experimental. #46642 (comment) |
nodejs-github-bot
commented
Apr 17, 2023
Collaborator
nodejs-github-bot
commented
Apr 17, 2023
Collaborator
jasnell
approved these changes
Apr 17, 2023
35 tasks
nodejs-github-bot
commented
Apr 18, 2023
Collaborator
Landed in d3b0a2a |
targos pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47579 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47579 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow added a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47579 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is a little distracting that the summary of failures includes both failing tests and their parents