Uh oh!
There was an error while loading. Please reload this page.
esm: remove support for deprecated hooks - #47580
Merged
Merged
Conversation
Those have been deprecated for a while, it's time.
nodejs-github-bot
commented
Apr 16, 2023
Collaborator
Review requested:
|
nodejs-github-bot
commented
Apr 16, 2023
Collaborator
VoltrexKeyva
approved these changes
Apr 16, 2023
nodejs-github-bot
commented
Apr 16, 2023
Collaborator
nodejs-github-bot
commented
Apr 16, 2023
Collaborator
targos
approved these changes
Apr 16, 2023
GeoffreyBooth
commented
Apr 16, 2023
Member
If we don't backport this, it might be hard to backport future loaders work. The whole API is still experimental, I think this can be backported. |
GeoffreyBooth
approved these changes
Apr 16, 2023
anonrig
approved these changes
Apr 16, 2023
jasnell
approved these changes
Apr 17, 2023
35 tasks
nodejs-github-bot
commented
Apr 18, 2023
Collaborator
nodejs-github-bot
commented
Apr 19, 2023
Collaborator
nodejs-github-bot
commented
Apr 19, 2023
Collaborator
nodejs-github-bot
commented
Apr 19, 2023
Collaborator
Landed in 7dd3732 |
This was referenced Apr 24, 2023
targos pushed a commit
that referenced
this pull request
May 2, 2023
Those have been deprecated for a while, it's time. PR-URL: #47580 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
Those have been deprecated for a while, it's time. PR-URL: nodejs#47580 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 23, 2023
Those have been deprecated for a while, it's time. PR-URL: #47580 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Those have been deprecated for a while, it's time. PR-URL: nodejs/node#47580 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Those have been deprecated for a while, it's time. PR-URL: nodejs/node#47580 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those have been deprecated for a while, it's time.