Uh oh!
There was an error while loading. Please reload this page.
fix: harden check for non-module in vm.modules linker - #47583
fix: harden check for non-module in vm.modules linker#47583MikeRalphson wants to merge 2 commits into
Conversation
Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
RaisinTen
commented
Apr 17, 2023
Should we add a test? Also, cc @nodejs/vm. |
MikeRalphson
commented
Apr 17, 2023
@RaisinTen should that be a simple test of the exception type? |
RaisinTen
commented
Apr 17, 2023
I think so, yes. |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
MikeRalphson
commented
Apr 18, 2023
Have found the relevant test file and am working up the new test function. |
MikeRalphson
commented
Apr 19, 2023
Is there a way to run just one of, or a subset of, the tests? |
RaisinTen
commented
Apr 19, 2023
Yea, you can run |
MikeRalphson
commented
Apr 19, 2023
Thanks @RaisinTen! |
aduh95
commented
Apr 19, 2023
You can also use |
fhinkel
commented
Feb 3, 2024
@MikeRalphson are you still working on the regression test or can somebody else pick this up? |
legendecas
commented
Mar 22, 2024
Landed in d1d5da2. |
Repro case: