doc: create maintaining folder for deps by marco-ippolito · Pull Request #47589 · nodejs/node

marco-ippolito · 2023-04-17T09:09:21Z

I would like to receive some feedback on this idea.
I wanted to move all the maintaining-x files under a common folder and I have created an overview file that lists all the dependencies and in a second iteration their version that will be updated by the tools.yml action.
Should we keep the name of the md files maintaing-x or just x?
@nodejs/security-wg
Refs: nodejs/security-wg#828

targos · 2023-04-17T09:40:33Z

SGTM

tniessen

Most of these files seem like they could be very short now that most is automated (and we don't want manual updates in most cases), maybe we could even put everything into a single document or so.

tniessen · 2023-04-17T15:55:51Z

This file does not really match the common theme since only a small part of it is about updating uvwasi.

marco-ippolito · 2023-04-17T16:24:11Z

probably there is no longer the need to describe the updating procedure because for most of them is automated and there is just one script thus making some maintaining.md useless

RafaelGSS · 2023-04-19T11:59:12Z

I think we should keep them in multiple files once the automation doesn't handle other active release lines. For instance, OpenSSL 1.x on v14 or OpenSSL 1.x+quic on v16 versions.

Also, I'm not sure about removing the maintaining files that were already covered by the update automation. It seems a good reference to perform maintenance in automation.

marco-ippolito · 2023-04-19T12:14:34Z

OpenSSL has its own maintaining file, I left the maintaining files for dependencies that have a complex procedure. Most of the ones I'm removing I created them and they were just execute dep_updaters/foo.sh. For the 14 release line is EOL, so we dont need to backport anymore right?

nodejs-github-bot · 2023-04-26T08:07:49Z

Commit Queue failed

- Loading data for nodejs/node/pull/47589
✔ Done loading data for nodejs/node/pull/47589
----------------------------------- PR info ------------------------------------
Title doc: create maintaining folder for deps (#47589)
Author Marco Ippolito (@marco-ippolito)
Branch marco-ippolito:feat/organize-maintaining -> nodejs:main
Labels doc, author ready
Commits 1
- doc: create maintaining folder for deps
Committers 1
- Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/47589
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: James M Snell Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47589
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: James M Snell Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga --------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - doc: create maintaining folder for deps
ℹ This PR was created on Mon, 17 Apr 2023 09:09:21 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/47589#pullrequestreview-1394928517
✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47589#pullrequestreview-1395787388
✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47589#pullrequestreview-1396007103
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4806355194

nodejs-github-bot · 2023-04-26T14:21:19Z

Commit Queue failed

- Loading data for nodejs/node/pull/47589
✔ Done loading data for nodejs/node/pull/47589
----------------------------------- PR info ------------------------------------
Title doc: create maintaining folder for deps (#47589)
Author Marco Ippolito (@marco-ippolito)
Branch marco-ippolito:feat/organize-maintaining -> nodejs:main
Labels doc, author ready
Commits 1
- doc: create maintaining folder for deps
Committers 1
- Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/47589
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: James M Snell Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47589
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: James M Snell Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga --------------------------------------------------------------------------------
ℹ This PR was created on Mon, 17 Apr 2023 09:09:21 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/47589#pullrequestreview-1394928517
✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47589#pullrequestreview-1395787388
✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47589#pullrequestreview-1402037281
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4809803241

mhdawson

LGTM

nodejs-github-bot · 2023-05-02T06:50:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51570/

nodejs-github-bot · 2023-05-02T14:48:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51579/

nodejs-github-bot · 2023-05-02T17:03:25Z

Landed in 109ab0a

PR-URL: #47589 Refs: nodejs/security-wg#828 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#47589 Refs: nodejs/security-wg#828 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 17, 2023

marco-ippolito force-pushed the feat/organize-maintaining branch from 9faad4b to d10d022Compare April 17, 2023 09:10

tniessen reviewed Apr 17, 2023
View reviewed changes

marco-ippolito marked this pull request as ready for review April 19, 2023 10:04

marco-ippolito force-pushed the feat/organize-maintaining branch 3 times, most recently from 05b4919 to 19d33feCompare April 19, 2023 10:26

marco-ippolito force-pushed the feat/organize-maintaining branch from 19d33fe to 7ada588Compare April 19, 2023 12:23

jasnell approved these changes Apr 21, 2023
View reviewed changes

marco-ippolito force-pushed the feat/organize-maintaining branch from 7ada588 to 6a56ccaCompare April 21, 2023 08:56

ShogunPanda approved these changes Apr 21, 2023
View reviewed changes

RafaelGSS approved these changes Apr 21, 2023
View reviewed changes

marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 24, 2023

marco-ippolito force-pushed the feat/organize-maintaining branch from 6a56cca to cab0fa8Compare April 24, 2023 08:39

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 26, 2023

marco-ippolito removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 26, 2023

RafaelGSS approved these changes Apr 26, 2023
View reviewed changes

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 26, 2023

marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 26, 2023

github-actionsBot mentioned this pull request Apr 27, 2023
CI Reliability 2023-04-27 nodejs/reliability#548
Open
35 tasks

UlisesGascon approved these changes Apr 27, 2023
View reviewed changes

github-actionsBot mentioned this pull request Apr 28, 2023
CI Reliability 2023-04-28 nodejs/reliability#549
Open
29 tasks

doc: create maintaining folder for deps
980fd28

marco-ippolito force-pushed the feat/organize-maintaining branch from 5686e44 to 980fd28Compare April 28, 2023 10:38

This was referenced Apr 29, 2023
CI Reliability 2023-04-29 nodejs/reliability#550
Open
CI Reliability 2023-04-30 nodejs/reliability#551
Open

marco-ippolito requested a review from mhdawson April 30, 2023 20:04

github-actionsBot mentioned this pull request May 1, 2023
CI Reliability 2023-05-01 nodejs/reliability#552
Open
33 tasks

mhdawson approved these changes May 1, 2023
View reviewed changes

github-actionsBot mentioned this pull request May 2, 2023
CI Reliability 2023-05-02 nodejs/reliability#553
Open
32 tasks

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2023

marco-ippolito mentioned this pull request May 2, 2023
Dependency update automation improvements nodejs/security-wg#973
Closed
9 tasks

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2023

nodejs-github-bot merged commit 109ab0a into nodejs:mainMay 2, 2023

github-actionsBot mentioned this pull request May 3, 2023
CI Reliability 2023-05-03 nodejs/reliability#554
Open
33 tasks

targos mentioned this pull request May 3, 2023
v20.1.0 release proposal #47820
Merged

This was referenced May 4, 2023
CI Reliability 2023-05-04 nodejs/reliability#555
Open
CI Reliability 2023-05-05 nodejs/reliability#556
Open

fasenderos mentioned this pull request May 27, 2023
doc: fix broken link to new folder doc/contributing/maintaining #48205
Merged

danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged

Navigation Menu

Uh oh!

Uh oh!

doc: create maintaining folder for deps - #47589

doc: create maintaining folder for deps#47589
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/organize-maintaining

marco-ippolito commented Apr 17, 2023•
edited
Loading

Uh oh!

targos commented Apr 17, 2023

Uh oh!

tniessen left a comment

Uh oh!

tniessenApr 17, 2023

Uh oh!

marco-ippolito commented Apr 17, 2023

Uh oh!

RafaelGSS commented Apr 19, 2023

Uh oh!

marco-ippolito commented Apr 19, 2023•
edited
Loading

Uh oh!

nodejs-github-bot commented Apr 26, 2023

Uh oh!

nodejs-github-bot commented Apr 26, 2023

Uh oh!

mhdawson left a comment •
edited
Loading

Uh oh!

nodejs-github-bot commented May 2, 2023

Uh oh!

nodejs-github-bot commented May 2, 2023

Uh oh!

nodejs-github-bot commented May 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Uh oh!

Conversation

marco-ippolito commented Apr 17, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Apr 17, 2023

Uh oh!

tniessen left a comment

Choose a reason for hiding this comment

Uh oh!

tniessenApr 17, 2023

Choose a reason for hiding this comment

Uh oh!

marco-ippolito commented Apr 17, 2023

Uh oh!

RafaelGSS commented Apr 19, 2023

Uh oh!

marco-ippolito commented Apr 19, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 26, 2023

Uh oh!

nodejs-github-bot commented Apr 26, 2023

Uh oh!

mhdawson left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 2, 2023

Uh oh!

nodejs-github-bot commented May 2, 2023

Uh oh!

nodejs-github-bot commented May 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

marco-ippolito commented Apr 17, 2023•
edited
Loading

marco-ippolito commented Apr 19, 2023•
edited
Loading

mhdawson left a comment •
edited
Loading