Skip to content

tools: automate v8 patch update - #47594

Merged
nodejs-github-bot merged 7 commits into
nodejs:mainfrom
marco-ippolito:feat/automate-v8-update
Apr 26, 2023
Merged

tools: automate v8 patch update#47594
nodejs-github-bot merged 7 commits into
nodejs:mainfrom
marco-ippolito:feat/automate-v8-update

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Apr 17, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Refs: nodejs/security-wg#828
please review carefully, first time approaching v8
if you know a way of creating a patch without cloning v8 (which is very expensive) that would be great
@nodejs/security-wg

@nodejs-github-bot

nodejs-github-bot commented Apr 17, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Apr 17, 2023
mscdex
mscdex reviewed Apr 17, 2023
View reviewed changes
Comment threadtools/dep_updaters/update-v8-patch.sh Outdated
@targos

targos commented Apr 17, 2023

Copy link
Copy Markdown
Member

Did you consider using the git node command? For the V8 clone, in the canary repo we use the GitHub actions cache

@marco-ippolito

marco-ippolito commented Apr 19, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@targos I basically copied what git node v8 minor was doing, I tried with the command but I had some issue with folder structure. I guess we can cache the v8 clone, should we create a new action specificly for this?

@marco-ippolito
marco-ippolitoforce-pushed the feat/automate-v8-update branch from 03b4a51 to f8da622CompareApril 21, 2023 10:28
@marco-ippolito

marco-ippolito commented Apr 21, 2023

Copy link
Copy Markdown
MemberAuthor

I have created a separate action to update v8, caching the git node v8 folder. @targos

targos
targos requested changes Apr 21, 2023
View reviewed changes
Comment thread.github/workflows/update-v8.yml Outdated
Comment thread.github/workflows/update-v8.yml Outdated
Comment thread.github/workflows/update-v8.yml Outdated
Comment thread.github/workflows/update-v8.yml Outdated
Comment threadtools/dep_updaters/update-v8-minor.sh Outdated
@marco-ippolito
marco-ippolitoforce-pushed the feat/automate-v8-update branch from f912fa3 to 0a46fe1CompareApril 21, 2023 15:59
targos
targos reviewed Apr 24, 2023
View reviewed changes
Comment thread.github/workflows/tools.yml Outdated
Comment threadtools/dep_updaters/update-v8-patch.sh
@marco-ippolito@targos
fix: cache only with v8
cf9270a
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@marco-ippolito

marco-ippolito commented Apr 24, 2023

Copy link
Copy Markdown
MemberAuthor

sorry for changing my mind a few times but due to the amount of dependencies I've decided to move it back to update-v8.yml

@marco-ippolito
marco-ippolitoforce-pushed the feat/automate-v8-update branch from 97e3b47 to 936482cCompareApril 24, 2023 09:27
targos
targos reviewed Apr 24, 2023
View reviewed changes
Comment thread.github/workflows/update-v8.yml Outdated
Comment thread.github/workflows/update-v8.yml Outdated
Comment thread.github/workflows/update-v8.yml Outdated
Comment thread.github/workflows/update-v8.yml Outdated
targos
targos reviewed Apr 24, 2023
View reviewed changes
Comment thread.github/workflows/update-v8.yml Outdated
@marco-ippolito
marco-ippolitoforce-pushed the feat/automate-v8-update branch from d115ed1 to a7c237cCompareApril 24, 2023 09:57
@marco-ippolito
marco-ippolitoforce-pushed the feat/automate-v8-update branch from a7c237c to 9e5b634CompareApril 24, 2023 10:00
targos
targos reviewed Apr 24, 2023
View reviewed changes
Comment thread.github/workflows/update-v8.yml Outdated
marco-ippolito
marco-ippolito commented Apr 24, 2023
View reviewed changes
Comment threadtools/dep_updaters/update-v8-patch.sh Outdated
@marco-ippolitomarco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Apr 26, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 71a776b into nodejs:mainApr 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

Landed in 71a776b

@targos

targos commented Apr 26, 2023

Copy link
Copy Markdown
Member

It doesn't work: https://github.com/nodejs/node/actions/runs/4807223999/jobs/8555708692

targos pushed a commit that referenced this pull request May 2, 2023
@marco-ippolito@targos
tools: automate v8 patch update
63e8c95
PR-URL: #47594
Refs: nodejs/security-wg#828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targostargos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@marco-ippolito@danielleadams
tools: automate v8 patch update
a072bfc
PR-URL: #47594
Refs: nodejs/security-wg#828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@marco-ippolito@MoLow
tools: automate v8 patch update
4e0d19e
PR-URL: nodejs#47594
Refs: nodejs/security-wg#828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@targostargostargos approved these changes
@UlisesGasconUlisesGasconUlisesGascon approved these changes
+1 more reviewer
@mscdexmscdexmscdex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@marco-ippolito@nodejs-github-bot@targos@mscdex@ShogunPanda@UlisesGascon