Uh oh!
There was an error while loading. Please reload this page.
Add the missing LoongArch64 definition in the v8.gyp file. - #47641
Closed
sunhaiyong1978 wants to merge 1 commit into
Closed
Add the missing LoongArch64 definition in the v8.gyp file.#47641sunhaiyong1978 wants to merge 1 commit into
sunhaiyong1978 wants to merge 1 commit into
Conversation
nodejs-github-bot
commented
Apr 20, 2023
Collaborator
Review requested:
|
targos
approved these changes
Apr 20, 2023
anonrig
approved these changes
Apr 20, 2023
richardlau
approved these changes
Apr 20, 2023
VoltrexKeyva
approved these changes
Apr 20, 2023
lpinca
approved these changes
Apr 20, 2023
sunhaiyong1978
commented
Apr 21, 2023
ContributorAuthor
Modify the title, because the check failed due to the original title being too long. |
gengjiawen
approved these changes
Apr 21, 2023
nodejs-github-bot
commented
Apr 21, 2023
Collaborator
nodejs-github-bot
commented
Apr 21, 2023
Collaborator
nodejs-github-bot
commented
Apr 21, 2023
Collaborator
sunhaiyong1978
commented
Apr 21, 2023
ContributorAuthor
Modify the title again, because the title check failed. |
VoltrexKeyva
commented
Apr 21, 2023
Contributor
Hey @sunhaiyong1978, it seems like your commit has an invalid user (basically doesn't point to you), make sure you've configured Git with the appropriate details so that you would be shown as a contributor after this gets merged. This is generally the cause of the incorrect email being used, make sure it is set to the primary email of your GitHub account by running the following: $ git config --global user.email "<The primary email>"(Replace And then do a force-push. |
sunhaiyong1978
commented
Apr 21, 2023
ContributorAuthor
Okay, I have modified my submission email. |
39 tasks
aymen94
approved these changes
Apr 24, 2023
This was referenced Apr 25, 2023
nodejs-github-bot
commented
Apr 26, 2023
Collaborator
nodejs-github-bot
commented
Apr 26, 2023
Collaborator
nodejs-github-bot
commented
Apr 26, 2023
Collaborator
35 tasks
sunhaiyong1978
commented
Apr 27, 2023
ContributorAuthor
I received 3 failing checks , but it seems that they are not caused by the pull request I submitted. What should I do next? |
nodejs-github-bot
commented
Apr 27, 2023
Collaborator
This was referenced Apr 28, 2023
targos
commented
May 1, 2023
Member
Landed in aa6600d |
targos pushed a commit
that referenced
this pull request
May 1, 2023
PR-URL: #47641 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
32 tasks
targos pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47641 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit
that referenced
this pull request
May 3, 2023
PR-URL: #47641 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the tools/v8_gypfiles/v8.gyp file, there is a missing definition for the LoongArch64 architecture (defined as loong64 in v8). This can lead to errors when compiling node.js that supports v8 on the LoongArch64 architecture.