Skip to content

doc,fs: update description of fs.stat() method - #47654

Merged
nodejs-github-bot merged 5 commits into
nodejs:mainfrom
mertcanaltin:dev-4
Apr 23, 2023
Merged

doc,fs: update description of fs.stat() method#47654
nodejs-github-bot merged 5 commits into
nodejs:mainfrom
mertcanaltin:dev-4

Conversation

@mertcanaltin

@mertcanaltinmertcanaltin commented Apr 21, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Hi as mentioned in the talk, fs.stat watches the symlinks, while fs.lstat looks at the symlinks themselves. For this reason, it is recommended to use fs.lstat in cases where symlinks themselves need to be looked at. Based on this information I added that you should use fs.stat or fs.lstat depending on the type of file

Fixes: #47633

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Apr 21, 2023
@mertcanaltinmertcanaltin changed the title fs: update fs.stat descriptiondoc,fs: update description of fs.stat() methodApr 21, 2023
RaisinTen
RaisinTen reviewed Apr 21, 2023
View reviewed changes
Comment threaddoc/api/fs.md Outdated
Comment threaddoc/api/fs.md Outdated
@mertcanaltin

mertcanaltin commented Apr 21, 2023

Copy link
Copy Markdown
MemberAuthor

Thank you very much for the review and corrections. @RaisinTen

mertcanaltinand others added 2 commits April 21, 2023 09:51
@mertcanaltin@RaisinTen
Update doc/api/fs.md
cc9b271
Co-authored-by: Darshan Sen <raisinten@gmail.com>
@mertcanaltin@RaisinTen
Update doc/api/fs.md
3d9c6bd
Co-authored-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
RaisinTen approved these changes Apr 21, 2023
View reviewed changes

@RaisinTenRaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @nodejs/fs

@RaisinTenRaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 21, 2023
@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 21, 2023
targos
targos reviewed Apr 21, 2023
View reviewed changes
Comment threaddoc/api/fs.md Outdated
@mertcanaltin@targos
Update doc/api/fs.md
6208ed8
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@mertcanaltin

mertcanaltin commented Apr 21, 2023

Copy link
Copy Markdown
MemberAuthor

@targos Thank you very much for your suggestion, I sent a commit

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 511d40c into nodejs:mainApr 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 511d40c

targos pushed a commit that referenced this pull request May 2, 2023
@mertcanaltin@targos
doc,fs: update description of fs.stat() method
09ff9ea
PR-URL: #47654Fixes: #47633
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@targostargos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@mertcanaltin@danielleadams
doc,fs: update description of fs.stat() method
6bf0b00
PR-URL: #47654Fixes: #47633
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@mertcanaltin@MoLow
doc,fs: update description of fs.stat() method
8651ea8
PR-URL: nodejs#47654Fixes: nodejs#47633
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos left review comments
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@daeyeondaeyeondaeyeon approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
@LiviaMedeirosLiviaMedeirosLiviaMedeiros approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

statSync fails in detecting link

9 participants

@mertcanaltin@nodejs-github-bot@lpinca@anonrig@targos@daeyeon@RaisinTen@VoltrexKeyva@LiviaMedeiros