Skip to content

test: port flaky wpt/html/webappapis/timers tests to test/sequential - #47657

Closed
panva wants to merge 1 commit into
nodejs:mainfrom
panva:move-flaky-wpt
Closed

test: port flaky wpt/html/webappapis/timers tests to test/sequential#47657
panva wants to merge 1 commit into
nodejs:mainfrom
panva:move-flaky-wpt

Conversation

@panva

@panvapanva commented Apr 21, 2023

Copy link
Copy Markdown
Member

wpt/test-timers has been unreliable since we've re-enabled parallel execution in WPTs. This PR removes the html/webappapis/timers WPTs and ports the tests to test/sequential instead.

e.g.
nodejs/reliability#548
image

@panvapanva added timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. test Issues and PRs related to the tests. labels Apr 21, 2023
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 21, 2023
@panva

Copy link
Copy Markdown
MemberAuthor

cc @nodejs/timers

@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panvapanva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 22, 2023
@tniessen

Copy link
Copy Markdown
Member

I understand the motivation, but is there an alternative, such as adding an option to run some WPTs sequentially or so?

@panva

Copy link
Copy Markdown
MemberAuthor

I understand the motivation, but is there an alternative, such as adding an option to run some WPTs sequentially or so?

Not when the other WPT suites execute in parallel. The problem appears to be in used up resources, and with webcrypto hogging those up...

@panvapanva added the review wanted PRs that need reviews. label Apr 26, 2023
@panvapanva added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Apr 27, 2023
@panva

panva commented May 3, 2023

Copy link
Copy Markdown
MemberAuthor

ping @nodejs/timers

@targos

Copy link
Copy Markdown
Member

Not when the other WPT suites execute in parallel. The problem appears to be in used up resources, and with webcrypto hogging those up...

If we're already parallelizing WPT suites in the WPT runner, shouldn't we run test/wpt sequentially?

@panva

panva commented May 3, 2023

Copy link
Copy Markdown
MemberAuthor

Not when the other WPT suites execute in parallel. The problem appears to be in used up resources, and with webcrypto hogging those up...

If we're already parallelizing WPT suites in the WPT runner, shouldn't we run test/wpt sequentially?

I'm just looking at nodejs/reliability and wpt/test-webcrypto also occasionally crashes. So i'm going to open a PR reverting the python side of things to sequential and also introducing maximum parallelism option in the WPTRunner.

@panvapanva mentioned this pull request May 3, 2023
@panva

panva commented May 3, 2023

Copy link
Copy Markdown
MemberAuthor

Closing in favour of #47834

@panvapanva closed this May 3, 2023
@panva
panva deleted the move-flaky-wpt branch August 22, 2025 14:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.flaky-testIssues and PRs related to the tests with unstable failures on the CI.needs-ciPRs that need a full CI run.review wantedPRs that need reviews.testIssues and PRs related to the tests.timersIssues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@panva@nodejs-github-bot@tniessen@targos@anonrig