Skip to content

path: indicate index of wrong resolve() parameter - #47660

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
sosoba:patch-1
May 4, 2023
Merged

path: indicate index of wrong resolve() parameter#47660
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
sosoba:patch-1

Conversation

@sosoba

@sosobasosoba commented Apr 21, 2023

Copy link
Copy Markdown
Contributor

Index of wrong parameter

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. labels Apr 21, 2023
@sosobasosoba changed the title [impr] Indicate index of wrong join() parameternode:path indicate index of wrong join() parameterApr 21, 2023
@sosobasosoba changed the title node:path indicate index of wrong join() parameterpath: indicate index of wrong join() parameterApr 21, 2023
tniessen
tniessen reviewed Apr 21, 2023
View reviewed changes
Comment threadlib/path.js Outdated
tniessen
tniessen reviewed Apr 26, 2023
View reviewed changes

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @sosoba. Could you please remove the merge commits from your branch patch-1, for example, by rebasing locally?

Also, while the title of the PR says that this affects join(), it seems to me that the diff targets resolve() but not join().

Comment threadlib/path.js Outdated
Comment threadlib/path.js Outdated
@sosobasosoba changed the title path: indicate index of wrong join() parameterpath: indicate index of wrong resolve() parameterApr 26, 2023
@deokjinkim

deokjinkim commented Apr 27, 2023

Copy link
Copy Markdown
Contributor

@sosoba Could you please squash 8 commits to 1 commit using git rebase -i? And please follow Commit message guidelines. For example, commit title needs to be started with subsystem like path: show index of wrong resolve() parameter.

https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

@sosoba

sosoba commented Apr 27, 2023

Copy link
Copy Markdown
ContributorAuthor

git rebase -i

Rebased!

@deokjinkim

deokjinkim commented Apr 28, 2023

Copy link
Copy Markdown
Contributor

@sosoba I mean squash(not rebase) in git. Squash in git means to combine multiple commits into one. You can squash using git rebase -i command. Here is guide for squash in git.

https://medium.com/@slamflipstrom/a-beginners-guide-to-squashing-commits-with-git-rebase-8185cf6e62ec

And need to follow commit message guideline I mentioned above.

@tniessen

tniessen commented Apr 28, 2023

Copy link
Copy Markdown
Member

@sosoba You will need to checkout your branch locally and remove the merge commits. You can optionally squash the non-merge commits on this branch, but in any case, the commit message of the first commit should follow our guidelines (and match the PR title).

If you would like us to do this for you, just let me know.

@sosoba

sosoba commented Apr 28, 2023

Copy link
Copy Markdown
ContributorAuthor

If you would like us to do this for you, just let me know.

Please. My attempts failed.

@tniessentniessen added the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2023
@nodejs-github-bot

nodejs-github-bot commented May 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51622/

@nodejs-github-bot

nodejs-github-bot commented May 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51624/

@deokjinkimdeokjinkim added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 4, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b7def8e into nodejs:mainMay 4, 2023
@nodejs-github-bot

nodejs-github-bot commented May 4, 2023

Copy link
Copy Markdown
Collaborator

Landed in b7def8e

targos pushed a commit that referenced this pull request May 12, 2023
@sosoba@targos
path: indicate index of wrong resolve() parameter
7222f9d
PR-URL: #47660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
@targostargos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@sosoba@danielleadams
path: indicate index of wrong resolve() parameter
8f7189f
PR-URL: #47660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@sosoba@MoLow
path: indicate index of wrong resolve() parameter
b34eaf3
PR-URL: nodejs#47660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessentniessentniessen approved these changes
@deokjinkimdeokjinkimdeokjinkim approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.pathIssues and PRs related to the path subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sosoba@deokjinkim@tniessen@nodejs-github-bot