Uh oh!
There was an error while loading. Please reload this page.
esm: rename URLCanParse to be consistent - #47668
Merged
Merged
Conversation
nodejs-github-bot
commented
Apr 22, 2023
Collaborator
Review requested:
|
targos
approved these changes
Apr 22, 2023
nodejs-github-bot
commented
Apr 22, 2023
Collaborator
JakobJingleheimer
approved these changes
Apr 22, 2023
KhafraDev
approved these changes
Apr 22, 2023
anonrig
approved these changes
Apr 22, 2023
lpinca
approved these changes
Apr 22, 2023
jasnell
approved these changes
Apr 22, 2023
nodejs-github-bot
commented
Apr 24, 2023
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47668 ✔ Done loading data for nodejs/node/pull/47668 ----------------------------------- PR info ------------------------------------ Title esm: rename `URLCanParse` to be consistent (#47668) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:url-can-parse -> nodejs:main Labels esm, author ready, needs-ci Commits 1 - esm: rename `URLCanParse` to be consistent Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/47668 Reviewed-By: Michaël Zasso Reviewed-By: Jacob Smith Reviewed-By: Matthew Aitken Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47668 Reviewed-By: Michaël Zasso Reviewed-By: Jacob Smith Reviewed-By: Matthew Aitken Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 22 Apr 2023 10:30:51 GMT ✔ Approvals: 6 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/47668#pullrequestreview-1396671298 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/47668#pullrequestreview-1396699066 ✔ - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/47668#pullrequestreview-1396740885 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47668#pullrequestreview-1396752572 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47668#pullrequestreview-1396762264 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/47668#pullrequestreview-1396784206 ⚠ This PR has conflicts that must be resolved ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-04-22T11:04:00Z: https://ci.nodejs.org/job/node-test-pull-request/51407/ - Querying data for job/node-test-pull-request/51407/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4785284846 |
aymen94
approved these changes
Apr 24, 2023
PR-URL: nodejs#47668 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
commented
Apr 24, 2023
ContributorAuthor
Landed in d6c0b81 |
targos pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47668 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
commented
Jul 3, 2023
Contributor
Blocked by #47541 |
targos pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#47668 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 23, 2023
PR-URL: #47668 Backport-PR-URL: #50669 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#47668 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#47668 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urlcanParseis consistent with e.g. how primordials are named.