Skip to content

deps: update ada to 2.2.0 - #47678

Merged
nodejs-github-bot merged 2 commits into
mainfrom
actions/tools-update-ada
Apr 25, 2023
Merged

deps: update ada to 2.2.0#47678
nodejs-github-bot merged 2 commits into
mainfrom
actions/tools-update-ada

Conversation

@nodejs-github-bot

@nodejs-github-botnodejs-github-bot commented Apr 23, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of ada to 2.2.0.

@nodejs-github-botnodejs-github-bot added the dependencies Pull requests that update a dependency file. label Apr 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Review requested:

  • @nodejs/url

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 23, 2023
@anonrig

anonrig commented Apr 23, 2023•
edited
Loading

Copy link
Copy Markdown
Member

We have couple of breaking changes. I'll update this pull request.

@anonriganonrig self-assigned this Apr 23, 2023
@anonriganonrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 23, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/51440/

@anonrig

anonrig commented Apr 23, 2023

Copy link
Copy Markdown
Member

@nodejs/url please review

@nodejs-github-bot

nodejs-github-bot commented Apr 24, 2023

Copy link
Copy Markdown
CollaboratorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/51441/

@github-actionsgithub-actionsBot mentioned this pull request Apr 24, 2023
Open
39 tasks
@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 24, 2023
benjamingr
benjamingr approved these changes Apr 24, 2023
View reviewed changes

@benjamingrbenjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2023
@github-actionsgithub-actionsBot mentioned this pull request Apr 25, 2023
Open
38 tasks
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 25b6ddf into mainApr 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 25, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Landed in 25b6ddf

@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-ada branch April 25, 2023 00:47
This was referenced Apr 26, 2023
Open
Open
Open
@github-actionsgithub-actionsBot mentioned this pull request Apr 29, 2023
Open
32 tasks
targos pushed a commit that referenced this pull request May 2, 2023
@nodejs-github-bot@targos
deps: update ada to 2.2.0
f3ee312
PR-URL: #47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targostargos mentioned this pull request May 2, 2023
Merged
@anonriganonrig mentioned this pull request Jun 5, 2023
Closed
19 tasks
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
@nodejs-github-bot@anonrig
deps: update ada to 2.2.0
40d27a7
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot@danielleadams
deps: update ada to 2.2.0
42e690f
PR-URL: #47678
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@anonriganonriganonrig approved these changes
+1 more reviewer
@aymen94aymen94aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@anonriganonrig

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.dependenciesPull requests that update a dependency file.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nodejs-github-bot@anonrig@benjamingr@aymen94@danielleadams