Uh oh!
There was an error while loading. Please reload this page.
test: remove Object.observe from tests - #4769
Closed
vkurchatkin wants to merge 1 commit into
Closed
Conversation
silverwind
commented
Jan 19, 2016
Contributor
Do we know when v8 will drop it? |
cjihrig
commented
Jan 19, 2016
Contributor
LGTM if the CI is happy, although we should probably keep the tests as long as our V8 ships |
vkurchatkin
commented
Jan 19, 2016
ContributorAuthor
@cjihrig we could, but to tell the truth, it doesn't really add value in this particular case |
silverwind
commented
Jan 19, 2016
Contributor
Found it: https://groups.google.com/a/chromium.org/forum/#!topic/blink-reviews-bindings/vwyJiq5u38E
|
mgol
commented
Jan 19, 2016
Contributor
It says about deprecating, not dropping, though. |
silverwind
commented
Jan 20, 2016
Contributor
How about skipping the test if |
cjihrig
commented
Jan 20, 2016
Contributor
Is there any real rush to get rid of this? Is it hindering anything at all? |
Fishrock123
commented
Jan 20, 2016
Contributor
@cjihrig It fails in Chakra because uh, Chakra doesn't have it since it's no-longer spec. |
bnoordhuis
commented
Jan 20, 2016
Member
LGTM. It's non-spec so let's get rid of it. |
bnoordhuis
commented
Jan 20, 2016
Member
cjihrig
commented
Jan 20, 2016
Contributor
Makes sense then. LGTM |
mscdex
commented
Jan 20, 2016
Contributor
LGTM assuming the two test failures on pi1 in CI are unrelated. |
jasnell
commented
Jan 22, 2016
Member
They appear to be unrelated. |
silverwind
commented
Jan 27, 2016
Contributor
Thanks! Landed in b4313cf. |
silverwind pushed a commit
that referenced
this pull request
Jan 27, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
ChALkeR
commented
Jan 27, 2016
Member
I was under an impression that they already did drop it, but it seems they re-enabled it again due to backwards compatibility with something. |
rvagg pushed a commit
that referenced
this pull request
Jan 28, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg pushed a commit
that referenced
this pull request
Feb 8, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
that referenced
this pull request
Feb 17, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
that referenced
this pull request
Feb 18, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Mar 2, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (nodejs#4765) for obvious reason. PR-URL: nodejs#4769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing this wasn't really useful, besides Object.observe is going to be deprecated.
Also this test fails with Chakra (#4765) for obvious reason.