Skip to content

url: reduce revokeObjectURL cpp calls - #47728

Merged
nodejs-github-bot merged 1 commit into
mainfrom
perf-revoke-object-url
Apr 30, 2023
Merged

url: reduce revokeObjectURL cpp calls#47728
nodejs-github-bot merged 1 commit into
mainfrom
perf-revoke-object-url

Conversation

@anonrig

@anonriganonrig commented Apr 26, 2023

Copy link
Copy Markdown
Member

Resolving a pending TODO. This pull request mainly reduces the C++ calls in revokeObjectURL function while removing the try/catch block.

cc @nodejs/url

@nodejs-github-bot

nodejs-github-bot commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Apr 26, 2023
@anonrig
anonrigforce-pushed the perf-revoke-object-url branch from 0b485ec to e67eafdCompareApril 26, 2023 14:44
lemire
lemire reviewed Apr 26, 2023
View reviewed changes
Comment threadsrc/node_blob.cc Outdated
@anonrig
anonrigforce-pushed the perf-revoke-object-url branch from e67eafd to 3e6638bCompareApril 26, 2023 15:34
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51483/

@nodejs-github-bot

nodejs-github-bot commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51486/

@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51494/

@github-actionsgithub-actionsBot mentioned this pull request Apr 27, 2023
Open
35 tasks
This was referenced Apr 28, 2023
Open
Open
Open
@debadree25debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 30, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 30, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 6827dbb into mainApr 30, 2023
@nodejs-github-bot
nodejs-github-bot deleted the perf-revoke-object-url branch April 30, 2023 12:38
@nodejs-github-bot

nodejs-github-bot commented Apr 30, 2023

Copy link
Copy Markdown
Collaborator

Landed in 6827dbb

debadree25 added a commit to debadree25/node that referenced this pull request Apr 30, 2023
@debadree25
src: add a fast call for URL.revokeObjectURL
869ff2a
Refs: nodejs#47728
@debadree25debadree25 mentioned this pull request Apr 30, 2023
Draft
This was referenced May 1, 2023
Open
Open
targos pushed a commit that referenced this pull request May 2, 2023
@anonrig@targos
url: reduce revokeObjectURL cpp calls
821b3cd
PR-URL: #47728
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@targostargos mentioned this pull request May 2, 2023
Merged
targos pushed a commit that referenced this pull request May 3, 2023
@anonrig@targos
url: reduce revokeObjectURL cpp calls
e4b6b79
PR-URL: #47728
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@dario-piotrowiczdario-piotrowicz mentioned this pull request May 13, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lemirelemirelemire left review comments
@jasnelljasnelljasnell approved these changes
+1 more reviewer
@debadree25debadree25debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@lemire@jasnell@debadree25@danielleadams