Skip to content

test_runner: fix --require with --experimental-loader - #47751

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:loader-and-require
Apr 29, 2023
Merged

test_runner: fix --require with --experimental-loader#47751
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:loader-and-require

Conversation

@MoLow

@MoLowMoLow commented Apr 27, 2023•
edited
Loading

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 27, 2023
@MoLow

MoLow commented Apr 27, 2023

Copy link
Copy Markdown
MemberAuthor

CC @nodejs/loaders

GeoffreyBooth
GeoffreyBooth reviewed Apr 27, 2023
View reviewed changes
Comment threadtest/fixtures/test-runner/esm/bootloader.js Outdated
Comment threadsrc/api/environment.cc Outdated
Comment threadtest/parallel/test-runner-cli.js Outdated
Comment threadtest/fixtures/test-runner/esm/loader.mjs Outdated
Comment threadtest/parallel/test-runner-cli.js Outdated
@MoLowMoLow changed the title test_runner: fix --require with --experimental-loadertest_runner: fix --require with --experimental-loaderApr 27, 2023
JakobJingleheimer
JakobJingleheimer approved these changes Apr 29, 2023
View reviewed changes

@JakobJingleheimerJakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah! Thanks for this!

Approving presumptively as the core change of this PR is 👍

Comment threadtest/fixtures/test-runner/esm/loader.mjs Outdated
aduh95
aduh95 reviewed Apr 29, 2023
View reviewed changes
Comment threadtest/fixtures/test-runner/esm/loader.mjs Outdated
aduh95
aduh95 reviewed Apr 29, 2023
View reviewed changes
Comment threadtest/parallel/test-runner-cli.js Outdated
@MoLow
MoLowforce-pushed the loader-and-require branch from e0a0d48 to e6d1302CompareApril 29, 2023 19:49
@GeoffreyBoothGeoffreyBooth added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2023
@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51547/

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 1300ed0 into nodejs:mainApr 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1300ed0

@MoLow
MoLow deleted the loader-and-require branch April 30, 2023 03:56
targos pushed a commit that referenced this pull request May 2, 2023
@MoLow@targos
test_runner: fix --require with --experimental-loader
3618d31
PR-URL: #47751
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request May 2, 2023
Merged
targos pushed a commit that referenced this pull request May 3, 2023
@MoLow@targos
test_runner: fix --require with --experimental-loader
e5251e3
PR-URL: #47751
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow@danielleadams
test_runner: fix --require with --experimental-loader
838803c
PR-URL: #47751
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
test_runner: fix --require with --experimental-loader
8398bca
PR-URL: nodejs#47751
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@JakobJingleheimerJakobJingleheimerJakobJingleheimer approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MoLow@nodejs-github-bot@GeoffreyBooth@JakobJingleheimer@aduh95