Skip to content

quic: address recent coverity warning - #47753

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mhdawson:coverity-28
May 4, 2023
Merged

quic: address recent coverity warning#47753
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mhdawson:coverity-28

Conversation

@mhdawson

Copy link
Copy Markdown
Member

Address coverity warning about uninitialized value

Address coverity warning about uninitialized value
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v14.x needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Apr 27, 2023
@mhdawson

Copy link
Copy Markdown
MemberAuthor

Related coverity warning

128QuicError::QuicError(const std::string_view reason)
2. uninit_member: Non-staticclassmember error_.type is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-staticclassmember error_.error_code is not initialized in this constructor nor in any functions that it calls.
6. uninit_member: Non-staticclassmember error_.frame_type is not initialized in this constructor nor in any functions that it calls.
8. uninit_member: Non-staticclassmember error_.reason is not initialized in this constructor nor in any functions that it calls.
CID312510 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
10. uninit_member: Non-static class member error_.reasonlen is not initialized in this constructor nor in any functions that it calls.

@debadree25debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 28, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2023
@nodejs-github-bot
nodejs-github-bot merged commit d900912 into nodejs:mainMay 4, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in d900912

targos pushed a commit that referenced this pull request May 12, 2023
Address coverity warning about uninitialized value
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #47753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request May 15, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Address coverity warning about uninitialized value
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #47753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Address coverity warning about uninitialized value
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs#47753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.quicIssues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@mhdawson@nodejs-github-bot@jasnell@lpinca@anonrig@VoltrexKeyva@targos@debadree25