Skip to content

test: refactor to use getEventListeners in timers - #47759

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:230428_test_getEventListeners
May 3, 2023
Merged

test: refactor to use getEventListeners in timers#47759
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:230428_test_getEventListeners

Conversation

@deokjinkim

@deokjinkimdeokjinkim commented Apr 28, 2023

Copy link
Copy Markdown
Contributor

Use getEventListeners instead of listenerCount because #35991 was landed.

Refs: #35991
Refs: #36006

@deokjinkim
test: refactor to use getEventListeners in timers
c8e42f7
Use `getEventListeners` instead of `listenerCount` because nodejs#35991
was landed.
Refs: nodejs#35991
Refs: nodejs#36006
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 28, 2023
@deokjinkim
deokjinkim marked this pull request as draft April 28, 2023 10:28
@deokjinkim
deokjinkim marked this pull request as ready for review April 28, 2023 10:28
@daeyeondaeyeon added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 29, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51540/

This was referenced Apr 30, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented May 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51558/

@deokjinkim

deokjinkim commented May 1, 2023

Copy link
Copy Markdown
ContributorAuthor

@benjamingr PTAL because this PR fixes comment you leaved.

@github-actionsgithub-actionsBot mentioned this pull request May 2, 2023
Open
32 tasks
@deokjinkimdeokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 2, 2023
@nodejs-github-bot

nodejs-github-bot commented May 2, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/47759
✔ Done loading data for nodejs/node/pull/47759
----------------------------------- PR info ------------------------------------
Title test: refactor to use `getEventListeners` in timers (#47759)
Author Deokjin Kim (@deokjinkim)
Branch deokjinkim:230428_test_getEventListeners -> nodejs:main
Labels test, author ready, needs-ci
Commits 1
- test: refactor to use `getEventListeners` in timers
Committers 1
- Deokjin Kim PR-URL: https://github.com/nodejs/node/pull/47759
Refs: https://github.com/nodejs/node/pull/35991
Refs: https://github.com/nodejs/node/pull/36006
Reviewed-By: Daeyeon Jeong Reviewed-By: Benjamin Gruenbaum Reviewed-By: Mestery ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47759
Refs: https://github.com/nodejs/node/pull/35991
Refs: https://github.com/nodejs/node/pull/36006
Reviewed-By: Daeyeon Jeong Reviewed-By: Benjamin Gruenbaum Reviewed-By: Mestery --------------------------------------------------------------------------------
ℹ This PR was created on Fri, 28 Apr 2023 07:03:59 GMT
✔ Approvals: 3
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/47759#pullrequestreview-1406739223
✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47759#pullrequestreview-1407438184
✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/47759#pullrequestreview-1407449072
✘ Last GitHub CI failed
ℹ Last Full PR CI on 2023-05-01T07:59:33Z: https://ci.nodejs.org/job/node-test-pull-request/51558/
- Querying data for job/node-test-pull-request/51558/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4864775612

@deokjinkimdeokjinkim added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 2, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2023
@nodejs-github-bot

nodejs-github-bot commented May 2, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/47759
✔ Done loading data for nodejs/node/pull/47759
----------------------------------- PR info ------------------------------------
Title test: refactor to use `getEventListeners` in timers (#47759)
Author Deokjin Kim (@deokjinkim)
Branch deokjinkim:230428_test_getEventListeners -> nodejs:main
Labels test, author ready, needs-ci
Commits 1
- test: refactor to use `getEventListeners` in timers
Committers 1
- Deokjin Kim PR-URL: https://github.com/nodejs/node/pull/47759
Refs: https://github.com/nodejs/node/pull/35991
Refs: https://github.com/nodejs/node/pull/36006
Reviewed-By: Daeyeon Jeong Reviewed-By: Benjamin Gruenbaum Reviewed-By: Mestery ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47759
Refs: https://github.com/nodejs/node/pull/35991
Refs: https://github.com/nodejs/node/pull/36006
Reviewed-By: Daeyeon Jeong Reviewed-By: Benjamin Gruenbaum Reviewed-By: Mestery --------------------------------------------------------------------------------
ℹ This PR was created on Fri, 28 Apr 2023 07:03:59 GMT
✔ Approvals: 3
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/47759#pullrequestreview-1406739223
✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47759#pullrequestreview-1407438184
✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/47759#pullrequestreview-1407449072
✘ Last GitHub CI failed
ℹ Last Full PR CI on 2023-05-02T19:02:04Z: https://ci.nodejs.org/job/node-test-pull-request/51558/
- Querying data for job/node-test-pull-request/51558/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4865062346

@nodejs-github-botnodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 2, 2023
@github-actionsgithub-actionsBot mentioned this pull request May 3, 2023
Open
33 tasks
@deokjinkimdeokjinkim added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 3, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 3, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b0ca770 into nodejs:mainMay 3, 2023
@nodejs-github-bot

nodejs-github-bot commented May 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in b0ca770

@targostargos mentioned this pull request May 3, 2023
Merged
targos pushed a commit that referenced this pull request May 3, 2023
@deokjinkim@targos
test: refactor to use getEventListeners in timers
159cf02
Use `getEventListeners` instead of `listenerCount` because #35991
was landed.
Refs: #35991
Refs: #36006
PR-URL: #47759
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 4, 2023
Open
28 tasks
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@deokjinkim@danielleadams
test: refactor to use getEventListeners in timers
f533b36
Use `getEventListeners` instead of `listenerCount` because #35991
was landed.
Refs: #35991
Refs: #36006
PR-URL: #47759
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@deokjinkim@MoLow
test: refactor to use getEventListeners in timers
dedbeee
Use `getEventListeners` instead of `listenerCount` because nodejs#35991
was landed.
Refs: nodejs#35991
Refs: nodejs#36006
PR-URL: nodejs#47759
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@daeyeondaeyeondaeyeon approved these changes
+1 more reviewer
@MesteeryMesteeryMesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deokjinkim@nodejs-github-bot@benjamingr@daeyeon@Mesteery