Skip to content

doc: add valgrind suppression details - #47760

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
KevinEady:add-valgrind-suppression-info
May 4, 2023
Merged

doc: add valgrind suppression details#47760
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
KevinEady:add-valgrind-suppression-info

Conversation

@KevinEady

Copy link
Copy Markdown
Contributor

Adds details on how to generate and use Valgrind suppressions to the "Investigating memory leaks with Valgrind" documentation.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 28, 2023
@KevinEady
KevinEady marked this pull request as draft April 28, 2023 09:30
@KevinEady
KevinEadyforce-pushed the add-valgrind-suppression-info branch from 755386e to 2e457bdCompareApril 28, 2023 09:30
@KevinEady
KevinEady marked this pull request as ready for review April 28, 2023 10:14

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS

Copy link
Copy Markdown
Member

cc: @nodejs/diagnostics

@legendecaslegendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 4, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 2ad5ea6 into nodejs:mainMay 4, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 2ad5ea6

targos pushed a commit that referenced this pull request May 12, 2023
PR-URL: #47760
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targostargos mentioned this pull request May 15, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47760
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47760
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@KevinEady@nodejs-github-bot@RafaelGSS@lpinca@legendecas@mhdawson@tony-go