Uh oh!
There was an error while loading. Please reload this page.
Update webstreams.md - #47762
Closed
christiantakle wants to merge 1 commit into
Closed
Conversation
debadree25
approved these changes
Apr 28, 2023
debadree25
left a comment
Contributor
There was a problem hiding this comment.
Looks good!
could you just update your commit message according to the guidelines https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines
Thanks!
christiantakle
commented
Apr 28, 2023
ContributorAuthor
Haha knew something like this would happen. git clone git@github.com:christiantakle/node.git --depth=1 --branch=patch-1
# rename commit with lazygitgit push --force-with-leaseMeh will have to recreate. |
debadree25
commented
Apr 28, 2023
Contributor
ah i think git push -f would have been fine somehow --force-with-lease closes the PR I think? interesting |
christiantakle
commented
Apr 28, 2023
ContributorAuthor
Interesting indeed :D |
ContributorAuthor
Cloned pr #47766 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc: fix arrayBuffer alias typo
bufferwas aliased toarrayBufferin an example forarrayBuffer.