Skip to content

tools: update eslint to 8.39.0 - #47789

Closed
nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/tools-update-eslint
Closed

tools: update eslint to 8.39.0#47789
nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/tools-update-eslint

Conversation

@nodejs-github-bot

@nodejs-github-botnodejs-github-bot commented Apr 30, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of eslint to 8.39.0.

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 30, 2023
@Trott
Trottforce-pushed the actions/tools-update-eslint branch from 25eea44 to 8d83ae7CompareApril 30, 2023 01:04
Trott
Trott approved these changes Apr 30, 2023
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@MoLow
MoLow requested a review from TrottApril 30, 2023 04:13
@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 30, 2023
@MoLowMoLow added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Apr 30, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Trott

Trott commented Apr 30, 2023

Copy link
Copy Markdown
Member

I see there's a rebase label on here. If so, the two commits need to be reversed so that there isn't a failing commit. The alternative is to squash. I'll go ahead and reverse the two commits now.

@Trott
Trottforce-pushed the actions/tools-update-eslint branch from 1f9a0a5 to d092b15CompareApril 30, 2023 17:53
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2023
MoLow
MoLow approved these changes Apr 30, 2023
View reviewed changes

@MoLowMoLow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Trott

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 30, 2023

Copy link
Copy Markdown
CollaboratorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/51554/

@nodejs-github-bot

nodejs-github-bot commented Apr 30, 2023

Copy link
Copy Markdown
CollaboratorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/51555/

@nodejs-github-bot

nodejs-github-bot commented Apr 30, 2023

Copy link
Copy Markdown
CollaboratorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/51556/

This was referenced May 1, 2023
Open
Open
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2023
@nodejs-github-bot

nodejs-github-bot commented May 2, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Landed in 8587e3b...32778b8

nodejs-github-bot pushed a commit that referenced this pull request May 2, 2023
@MoLow@nodejs-github-bot
tools: fix jsdoc lint
9658d84
PR-URL: #47789
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
nodejs-github-bot added a commit that referenced this pull request May 2, 2023
@nodejs-github-bot
tools: update eslint to 8.39.0
32778b8
PR-URL: #47789
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
targos pushed a commit that referenced this pull request May 2, 2023
@MoLow@targos
tools: fix jsdoc lint
cf087e2
PR-URL: #47789
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
targos pushed a commit that referenced this pull request May 2, 2023
@nodejs-github-bot@targos
tools: update eslint to 8.39.0
24b3128
PR-URL: #47789
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@targostargos mentioned this pull request May 2, 2023
Merged
@github-actionsgithub-actionsBot mentioned this pull request May 3, 2023
Open
33 tasks
@targos

targos commented May 3, 2023

Copy link
Copy Markdown
Member

Depends on #47498 to land on v20.x

This was referenced May 4, 2023
Open
Open
@MoLowMoLow mentioned this pull request May 7, 2023
Closed
targos pushed a commit that referenced this pull request May 12, 2023
@MoLow@targos
tools: fix jsdoc lint
7323902
PR-URL: #47789
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
targos pushed a commit that referenced this pull request May 12, 2023
@nodejs-github-bot@targos
tools: update eslint to 8.39.0
36f7cfa
PR-URL: #47789
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@targostargos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow@danielleadams
tools: fix jsdoc lint
7a2094e
PR-URL: #47789
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@nodejs-github-bot@danielleadams
tools: update eslint to 8.39.0
0be4e03
PR-URL: #47789
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
tools: fix jsdoc lint
706c87d
PR-URL: nodejs#47789
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@nodejs-github-bot@MoLow
tools: update eslint to 8.39.0
951cc7b
PR-URL: nodejs#47789
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@MoLowMoLowMoLow approved these changes
+1 more reviewer
@MesteeryMesteeryMesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nodejs-github-bot@Trott@targos@lpinca@cjihrig@tniessen@MoLow@Mesteery