Uh oh!
There was an error while loading. Please reload this page.
src: rename SKIP_CHECK_SIZE to SKIP_CHECK_STRLEN - #47845
Merged
nodejs-github-bot merged 1 commit intoMay 10, 2023
Merged
Conversation
SKIP_CHECK_VALUE is a string literal, so its size is the length of the string in chars plus one. The buffer buf is also always null-terminated, so its size should match the size of SKIP_CHECK_VALUE, which is _not_ SKIP_CHECK_SIZE. Rename SKIP_CHECK_SIZE to be consistent with C/C++ terminology.
This comment was marked as off-topic.
This comment was marked as off-topic.
nodejs-github-bot
commented
May 9, 2023
Collaborator
tniessen
commented
May 9, 2023
MemberAuthor
ping @nodejs/platform-windows @nodejs/cpp-reviewers |
jasnell
approved these changes
May 10, 2023
RaisinTen
approved these changes
May 10, 2023
codebytere
approved these changes
May 10, 2023
tniessen
commented
May 10, 2023
MemberAuthor
Thanks for reviewing :) |
nodejs-github-bot
commented
May 10, 2023
Collaborator
Landed in 19afcba |
targos pushed a commit
that referenced
this pull request
May 12, 2023
SKIP_CHECK_VALUE is a string literal, so its size is the length of the string in chars plus one. The buffer buf is also always null-terminated, so its size should match the size of SKIP_CHECK_VALUE, which is _not_ SKIP_CHECK_SIZE. Rename SKIP_CHECK_SIZE to be consistent with C/C++ terminology. PR-URL: #47845 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jul 6, 2023
SKIP_CHECK_VALUE is a string literal, so its size is the length of the string in chars plus one. The buffer buf is also always null-terminated, so its size should match the size of SKIP_CHECK_VALUE, which is _not_ SKIP_CHECK_SIZE. Rename SKIP_CHECK_SIZE to be consistent with C/C++ terminology. PR-URL: #47845 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
MoLow pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
SKIP_CHECK_VALUE is a string literal, so its size is the length of the string in chars plus one. The buffer buf is also always null-terminated, so its size should match the size of SKIP_CHECK_VALUE, which is _not_ SKIP_CHECK_SIZE. Rename SKIP_CHECK_SIZE to be consistent with C/C++ terminology. PR-URL: nodejs#47845 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SKIP_CHECK_VALUEis a string literal, so its size is the length of the string inchars plus one. The bufferbufis also always null-terminated, so its size should match the size ofSKIP_CHECK_VALUE, which is notSKIP_CHECK_SIZE.Rename
SKIP_CHECK_SIZEto be consistent with C/C++ terminology.