process: add custom dir support for heapsnapshot-signal by MrJithil · Pull Request #47854 · nodejs/node

MrJithil · 2023-05-04T09:50:48Z

Ref: #47842

nodejs-github-bot · 2023-06-10T22:51:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52197/

MrJithil · 2023-08-22T09:17:00Z

@benjamingr all issues resolved. Please try to land this sooner. Its opened on 4th May.

Ceres6

I can't approve, but LGTM

ErickWendel

LGTM

nodejs-github-bot · 2023-09-05T13:31:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53742/

nodejs-github-bot · 2023-09-05T14:57:19Z

Commit Queue failed

- Loading data for nodejs/node/pull/47854
✔ Done loading data for nodejs/node/pull/47854
----------------------------------- PR info ------------------------------------
Title process: add custom dir support for heapsnapshot-signal (#47854)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch MrJithil:addCwdSupportOnHeapSnapshot -> nodejs:main
Labels process, needs-ci
Commits 1
- process: add custom dir support for heapsnapshot-signal
Committers 1
- Jithil P Ponnan PR-URL: https://github.com/nodejs/node/pull/47854
Refs: https://github.com/nodejs/node/issues/47842
Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum Reviewed-By: Joyee Cheung Reviewed-By: Erick Wendel ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47854
Refs: https://github.com/nodejs/node/issues/47842
Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum Reviewed-By: Joyee Cheung Reviewed-By: Erick Wendel --------------------------------------------------------------------------------
ℹ This PR was created on Thu, 04 May 2023 09:50:48 GMT
✔ Approvals: 4
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/47854#pullrequestreview-1419757000
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/47854#pullrequestreview-1432558181
✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/47854#pullrequestreview-1473519728
✔ - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/47854#pullrequestreview-1611054978
✘ Last GitHub CI failed
ℹ Last Full PR CI on 2023-09-05T13:31:34Z: https://ci.nodejs.org/job/node-test-pull-request/53742/
- Querying data for job/node-test-pull-request/53742/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6086313053

nodejs-github-bot · 2023-09-05T16:02:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53746/

PR-URL: nodejs#47854 Refs: nodejs#47842 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>

Trott · 2023-09-05T22:14:21Z

Landed in 5402185

PR-URL: #47854 Refs: #47842 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels May 4, 2023

MrJithil changed the title ~~internal: add custom dir support for heapsnapshot-signal~~[draft]internal: add custom dir support for heapsnapshot-signalMay 4, 2023

MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch from 18d913b to 577ffbdCompare May 4, 2023 11:10

MrJithil changed the title ~~[draft]internal: add custom dir support for heapsnapshot-signal~~internal: add custom dir support for heapsnapshot-signalMay 4, 2023

MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch 2 times, most recently from f6baa61 to 98cdeb0Compare May 4, 2023 11:32

joyeecheung reviewed May 4, 2023
View reviewed changes

Comment threadlib/internal/process/pre_execution.js Outdated

MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch from 98cdeb0 to 0cdc46fCompare May 5, 2023 03:52

MrJithil requested a review from joyeecheung May 6, 2023 02:23

jasnell approved these changes May 10, 2023
View reviewed changes

SteffenLanger mentioned this pull request May 17, 2023
allow set directory for heapsnapshot #39493
Closed

benjamingr approved these changes May 18, 2023
View reviewed changes

joyeecheung reviewed May 19, 2023
View reviewed changes

Comment threadlib/internal/process/pre_execution.js Outdated

MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch 2 times, most recently from 5bbc7b0 to 1410a68Compare May 20, 2023 06:04

MrJithil changed the title ~~internal: add custom dir support for heapsnapshot-signal~~process: add custom dir support for heapsnapshot-signalMay 20, 2023

MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch from 1410a68 to 3ce5cacCompare May 20, 2023 06:16

MrJithil requested a review from joyeecheung May 20, 2023 06:17

MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch 2 times, most recently from 10b4e01 to 5b1ce48Compare May 21, 2023 03:48

joyeecheung reviewed May 29, 2023
View reviewed changes

Comment threadtest/sequential/test-heapdump-flag-custom-dir.js Outdated

MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch 2 times, most recently from 06676d9 to 3f01bc9Compare June 9, 2023 09:09

joyeecheung approved these changes Jun 10, 2023
View reviewed changes

This was referenced Jun 11, 2023
CI Reliability 2023-06-11 nodejs/reliability#590
Open
CI Reliability 2023-06-12 nodejs/reliability#591
Open
CI Reliability 2023-06-13 nodejs/reliability#592
Open
CI Reliability 2023-06-14 nodejs/reliability#593
Open

Ceres6 reviewed Aug 14, 2023
View reviewed changes

Comment threadlib/internal/process/pre_execution.js

MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch 2 times, most recently from 067ee6e to 4e39087Compare August 22, 2023 09:10

MrJithil requested a review from Ceres6 August 22, 2023 09:11

MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch from 4e39087 to 08383f8Compare August 22, 2023 09:12

Ceres6 reviewed Aug 22, 2023
View reviewed changes

ErickWendel approved these changes Sep 5, 2023
View reviewed changes

ErickWendel added commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 5, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 5, 2023

Trott force-pushed the addCwdSupportOnHeapSnapshot branch from 08383f8 to 5402185Compare September 5, 2023 22:13

Trott merged commit 5402185 into nodejs:mainSep 5, 2023

This was referenced Sep 6, 2023
CI Reliability 2023-09-06 nodejs/reliability#657
Open
CI Reliability 2023-09-09 nodejs/reliability#660
Open

This was referenced Sep 16, 2023
src: fix --diagnostic-dir not working with --heapsnapshot-signal #49496
Closed
forcing heap snapshot via signal does not allow specifying custom directory #47842
Closed

This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged

Navigation Menu

Uh oh!

Uh oh!

process: add custom dir support for heapsnapshot-signal - #47854

process: add custom dir support for heapsnapshot-signal#47854
Trott merged 1 commit into
nodejs:mainfrom
MrJithil:addCwdSupportOnHeapSnapshot

MrJithil commented May 4, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 10, 2023

Uh oh!

Uh oh!

MrJithil commented Aug 22, 2023

Uh oh!

Ceres6 left a comment

Uh oh!

ErickWendel left a comment

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

Trott commented Sep 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

MrJithil commented May 4, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 10, 2023

Uh oh!

Uh oh!

MrJithil commented Aug 22, 2023

Uh oh!

Ceres6 left a comment

Choose a reason for hiding this comment

Uh oh!

ErickWendel left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

Trott commented Sep 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants