Skip to content

test: fix webcrypto wrap unwrap tests - #47876

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:webcrypto-wrap-unwrap-tests
May 7, 2023
Merged

test: fix webcrypto wrap unwrap tests#47876
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:webcrypto-wrap-unwrap-tests

Conversation

@panva

@panvapanva commented May 5, 2023•
edited
Loading

Copy link
Copy Markdown
Member

The wrap/unwrap promises are now properly handled.

Refs: #47864

cc @tniessen@fhanau

@panvapanva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto labels May 5, 2023
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label May 5, 2023
@panvapanva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 5, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2023
@nodejs-github-bot

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51654/

@panva

panva commented May 5, 2023

Copy link
Copy Markdown
MemberAuthor

Note: the tests did actually execute before, but would cause an unhandled rejection in the file if they failed instead of reporting properly.

@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2023
@nodejs-github-bot

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51662/

@nodejs-github-bot

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51664/

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2023
This was referenced May 6, 2023
Open
Open
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ecf1427 into nodejs:mainMay 7, 2023
@nodejs-github-bot

nodejs-github-bot commented May 7, 2023

Copy link
Copy Markdown
Collaborator

Landed in ecf1427

@panva
panva deleted the webcrypto-wrap-unwrap-tests branch May 7, 2023 11:31
This was referenced May 8, 2023
Open
Open
Open
Open
Open
targos pushed a commit that referenced this pull request May 12, 2023
@panva@targos
test: fix webcrypto wrap unwrap tests
7e34f77
Refs: #47864
PR-URL: #47876
Refs: #47864
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@panva@danielleadams
test: fix webcrypto wrap unwrap tests
43c967e
Refs: #47864
PR-URL: #47876
Refs: #47864
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@panva@MoLow
test: fix webcrypto wrap unwrap tests
81d8d95
Refs: nodejs#47864
PR-URL: nodejs#47876
Refs: nodejs#47864
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.webcrypto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@lpinca@tniessen