Skip to content

lib: update comment - #47884

Closed
sinkhaha wants to merge 1 commit into
nodejs:mainfrom
sinkhaha:fix/modify_comment
Closed

lib: update comment#47884
sinkhaha wants to merge 1 commit into
nodejs:mainfrom
sinkhaha:fix/modify_comment

Conversation

@sinkhaha

@sinkhahasinkhaha commented May 5, 2023

Copy link
Copy Markdown
Contributor

Description of change

update comment, rename NODE_MODULE_CONTEXT_AWARE_CPP to NODE_BINDING_CONTEXT_AWARE_CPP

Checklist

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@sinkhaha
fix: update comment
37efe98
rename NODE_MODULE_CONTEXT_AWARE_CPP to NODE_BINDING_CONTEXT_AWARE_CPP
@nodejs-github-bot

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules
  • @nodejs/startup

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 5, 2023
@sinkhahasinkhaha changed the title fix: update commentlib: update commentMay 5, 2023
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2023
@nodejs-github-bot

nodejs-github-bot commented May 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51675/

@nodejs-github-bot

nodejs-github-bot commented May 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51685/

This was referenced May 7, 2023
Open
Open
Open
Open
@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 10, 2023
@nodejs-github-bot

nodejs-github-bot commented May 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51738/

This was referenced May 11, 2023
Open
Open
@legendecas

legendecas commented May 12, 2023

Copy link
Copy Markdown
Member

Landed in 7812327

legendecas pushed a commit that referenced this pull request May 12, 2023
@sinkhaha@legendecas
lib: update comment
7812327
Rename NODE_MODULE_CONTEXT_AWARE_CPP to NODE_BINDING_CONTEXT_AWARE_CPP.
PR-URL: #47884
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 13, 2023
Open
Open
targos pushed a commit that referenced this pull request May 14, 2023
@sinkhaha@targos
lib: update comment
b8cef7c
Rename NODE_MODULE_CONTEXT_AWARE_CPP to NODE_BINDING_CONTEXT_AWARE_CPP.
PR-URL: #47884
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 15, 2023
@sinkhaha@targos
lib: update comment
a4fed6c
Rename NODE_MODULE_CONTEXT_AWARE_CPP to NODE_BINDING_CONTEXT_AWARE_CPP.
PR-URL: #47884
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request May 15, 2023
Merged
@sinkhaha
sinkhaha deleted the fix/modify_comment branch May 23, 2023 02:17
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@sinkhaha@danielleadams
lib: update comment
724e013
Rename NODE_MODULE_CONTEXT_AWARE_CPP to NODE_BINDING_CONTEXT_AWARE_CPP.
PR-URL: #47884
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@sinkhaha@MoLow
lib: update comment
2b65625
Rename NODE_MODULE_CONTEXT_AWARE_CPP to NODE_BINDING_CONTEXT_AWARE_CPP.
PR-URL: nodejs#47884
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sinkhaha@nodejs-github-bot@legendecas@jasnell@lpinca@joyeecheung