Skip to content

deps: update ada to 2.4.0 - #47922

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ada
May 9, 2023
Merged

deps: update ada to 2.4.0#47922
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ada

Conversation

@nodejs-github-bot

@nodejs-github-botnodejs-github-bot commented May 8, 2023•
edited by anonrig
Loading

Copy link
Copy Markdown
Collaborator

This is an automated update of ada to 2.4.0.

Fixes#47894

@nodejs-github-botnodejs-github-bot added the dependencies Pull requests that update a dependency file. label May 8, 2023
@nodejs-github-bot

nodejs-github-bot commented May 8, 2023•
edited by anonrig
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Review requested:

  • @nodejs/url

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label May 8, 2023
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels May 8, 2023
@github-actions

github-actionsBot commented May 8, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonrig

anonrig commented May 8, 2023

Copy link
Copy Markdown
Member

cc @RaisinTen@bnoordhuis@tniessen

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2023
@nodejs-github-bot

nodejs-github-bot commented May 8, 2023

Copy link
Copy Markdown
CollaboratorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/51703/

@anonriganonrig mentioned this pull request May 8, 2023
Closed
@github-actionsgithub-actionsBot mentioned this pull request May 9, 2023
Open
29 tasks
RaisinTen
RaisinTen approved these changes May 9, 2023
View reviewed changes

@RaisinTenRaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a6ad5d8 into mainMay 9, 2023
@nodejs-github-bot

nodejs-github-bot commented May 9, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Landed in a6ad5d8

@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-ada branch May 9, 2023 15:53
@github-actionsgithub-actionsBot mentioned this pull request May 10, 2023
Open
25 tasks
targos pushed a commit that referenced this pull request May 12, 2023
@nodejs-github-bot@targos
deps: update ada to 2.4.0
c2b14b4
PR-URL: #47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targostargos mentioned this pull request May 15, 2023
Merged
@anonriganonrig mentioned this pull request Jun 5, 2023
Closed
19 tasks
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
@nodejs-github-bot@anonrig
deps: update ada to 2.4.0
461c1e9
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot@danielleadams
deps: update ada to 2.4.0
81b514d
PR-URL: #47922
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lemirelemirelemire approved these changes
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dependenciesPull requests that update a dependency file.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ada's license

6 participants

@nodejs-github-bot@anonrig@lemire@lpinca@RaisinTen@danielleadams