Skip to content

test: remove race condition in http flood test - #4793

Closed
Trott wants to merge 4 commits into
nodejs:masterfrom
Trott:no-really
Closed

test: remove race condition in http flood test#4793
Trott wants to merge 4 commits into
nodejs:masterfrom
Trott:no-really

Conversation

@Trott

@TrottTrott commented Jan 21, 2016

Copy link
Copy Markdown
Member

Timer race results in some flakiness on slower devices in CI.

@Trott
test: remove race condition in http flood test
85bd422
Timer race results in some flakiness on slower devices in CI.
@TrottTrott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels Jan 21, 2016
@cjihrig

cjihrig commented Jan 21, 2016

Copy link
Copy Markdown
Contributor

LGTM if it works. Even if it doesn't work, nice to get those booleans out of there.

@jasnell

jasnell commented Jan 21, 2016

Copy link
Copy Markdown
Member

LGTM

@Trott

Trott commented Jan 21, 2016

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/1350/

@Trott

Trott commented Jan 21, 2016

Copy link
Copy Markdown
MemberAuthor

Will also need to back out the ES6-isms and confirm that it fails on Node 0.10.20 and passes on Node 0.10.21. Should probably add a comment about that.

@Trott

Trott commented Jan 24, 2016

Copy link
Copy Markdown
MemberAuthor

Alas, the test passes in 0.10.20, albeit after a very, very, very long time. Time to tweak the test some more...

@Trott

Trott commented Jan 24, 2016

Copy link
Copy Markdown
MemberAuthor

Checking that drain only fires once seems to make it fail reliably in 0.10.20 and pass in 0.10.21.

Running new version through CI: https://ci.nodejs.org/job/node-test-pull-request/1358/

PTAL @jasnell@cjihrig

@Trott

Trott commented Jan 24, 2016

Copy link
Copy Markdown
MemberAuthor

Raspberry Pi failure on CI, so that didn't do it either.

@Trott

Trott commented Jan 24, 2016

Copy link
Copy Markdown
MemberAuthor

Putting the socket timeout back to 200ms and re-running gives a pass: https://ci.nodejs.org/job/node-test-commit/1897/

Would like to run a stress test on Raspberry Pi to get a larger data set, though.

@Trott

Trott commented Jan 26, 2016

Copy link
Copy Markdown
MemberAuthor

I think this is ready to go, but since it's changed so much since the LGTM's, I'd like to just make sure it still gets 'em. @cjihrig@jasnell ?

@cjihrig

cjihrig commented Jan 27, 2016

Copy link
Copy Markdown
Contributor

Yep, LGTM if it works.

@Trott

Trott commented Jan 27, 2016

Copy link
Copy Markdown
MemberAuthor

Since the build team (Johan, I think) got Jenkins all snappy tonight, I'll try another CI run and HOPE FOR GREEN: https://ci.nodejs.org/job/node-test-pull-request/1390/

@Trott

Trott commented Jan 27, 2016

Copy link
Copy Markdown
MemberAuthor

Here we go: https://ci.nodejs.org/job/node-test-pull-request/1395/

Green! \o/

Trott added a commit to Trott/io.js that referenced this pull request Jan 27, 2016
@Trott
test: remove race condition in http flood test
cee14f5
Timer race results in some flakiness on slower devices in CI. Remove
unneeded setTimeout() and replace booleans with common.mustCall().
PR-URL: nodejs#4793
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

Trott commented Jan 27, 2016

Copy link
Copy Markdown
MemberAuthor

Landed in cee14f5

@TrottTrott closed this Jan 27, 2016
rvagg pushed a commit that referenced this pull request Jan 28, 2016
@Trott@rvagg
test: remove race condition in http flood test
31bc5c5
Timer race results in some flakiness on slower devices in CI. Remove
unneeded setTimeout() and replace booleans with common.mustCall().
PR-URL: #4793
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 8, 2016
@Trott@rvagg
test: remove race condition in http flood test
7f1e3e9
Timer race results in some flakiness on slower devices in CI. Remove
unneeded setTimeout() and replace booleans with common.mustCall().
PR-URL: #4793
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvaggrvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
@TrottMyles Borins
test: remove race condition in http flood test
c5f3cdd
Timer race results in some flakiness on slower devices in CI. Remove
unneeded setTimeout() and replace booleans with common.mustCall().
PR-URL: #4793
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@TrottMyles Borins
test: remove race condition in http flood test
6841d82
Timer race results in some flakiness on slower devices in CI. Remove
unneeded setTimeout() and replace booleans with common.mustCall().
PR-URL: #4793
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@TrottMyles Borins
test: remove race condition in http flood test
ce7101d
Timer race results in some flakiness on slower devices in CI. Remove
unneeded setTimeout() and replace booleans with common.mustCall().
PR-URL: #4793
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@TrottMichael Scovetta
test: remove race condition in http flood test
4bd1dfb
Timer race results in some flakiness on slower devices in CI. Remove
unneeded setTimeout() and replace booleans with common.mustCall().
PR-URL: nodejs#4793
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Trott deleted the no-really branch January 13, 2022 22:32
@baby636baby636 mentioned this pull request Oct 18, 2022
Open
@kissofirekissofire mentioned this pull request Oct 18, 2022
Open
This was referenced Oct 18, 2022
Open
Open
@QdigitalQdigital mentioned this pull request Oct 18, 2022
Open
This was referenced Oct 18, 2022
Open
Open
@MaxMood96MaxMood96 mentioned this pull request Oct 18, 2022
Open
@adamlaskaadamlaska mentioned this pull request Oct 18, 2022
Open
@ryan-allyryan-ally mentioned this pull request Oct 18, 2022
Open
@adamlaskaadamlaska mentioned this pull request Oct 18, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 18, 2022
Open
This was referenced Oct 18, 2022
Open
Open
@snyk-botsnyk-bot mentioned this pull request Oct 18, 2022
Open
@Verdinjoshua26Verdinjoshua26 mentioned this pull request Oct 19, 2022
Open
This was referenced Oct 19, 2022
Open
Open
This was referenced Oct 19, 2022
Open
Open
@baby636baby636 mentioned this pull request Oct 19, 2022
Open
@bsmoove247bsmoove247 mentioned this pull request Oct 19, 2022
Open
@baby636baby636 mentioned this pull request Oct 19, 2022
Open
@ryan-allyryan-ally mentioned this pull request Oct 19, 2022
Open
@ron-a20ron-a20 mentioned this pull request Oct 19, 2022
Open
@jhudazjhudaz mentioned this pull request Oct 19, 2022
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@cjihrig@jasnell@MylesBorins