Uh oh!
There was an error while loading. Please reload this page.
src: move BlobSerializerDeserializer to a separate header file - #47933
Closed
RaisinTen wants to merge 3 commits into
Closed
src: move BlobSerializerDeserializer to a separate header file#47933RaisinTen wants to merge 3 commits into
BlobSerializerDeserializer to a separate header file#47933RaisinTen wants to merge 3 commits into
Conversation
This should make it possible to reuse the BlobSerializer and the BlobDeserializer classes in SEAs to generate and parse the injected blob. This change also resolves this TODO: https://github.com/nodejs/node/blob/4f69aae6a04a460f267005dcf6551959064b3238/src/node_snapshotable.cc#L187 Refs: nodejs#47458 Signed-off-by: Darshan Sen <raisinten@gmail.com>
To keep the main header file readable and clean. Refs: https://github.com/nodejs/node/blob/4f69aae6a04a460f267005dcf6551959064b3238/src/README.md?plain=1#L52-L62 Signed-off-by: Darshan Sen <raisinten@gmail.com>
nodejs-github-bot
commented
May 9, 2023
Collaborator
Review requested:
|
joyeecheung
approved these changes
May 9, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
approved these changes
May 9, 2023
This comment was marked as outdated.
This comment was marked as outdated.
25 tasks
jasnell
reviewed
May 10, 2023
Uh oh!
There was an error while loading. Please reload this page.
Refs: nodejs#47933 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
May 10, 2023
Collaborator
24 tasks
RaisinTen added a commit
that referenced
this pull request
May 11, 2023
This should make it possible to reuse the BlobSerializer and the BlobDeserializer classes in SEAs to generate and parse the injected blob. This change also resolves this TODO: https://github.com/nodejs/node/blob/4f69aae6a04a460f267005dcf6551959064b3238/src/node_snapshotable.cc#L187 Refs: #47458 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #47933 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RaisinTen
commented
May 11, 2023
MemberAuthor
Landed in 78fe139 |
23 tasks
targos pushed a commit
that referenced
this pull request
May 12, 2023
This should make it possible to reuse the BlobSerializer and the BlobDeserializer classes in SEAs to generate and parse the injected blob. This change also resolves this TODO: https://github.com/nodejs/node/blob/4f69aae6a04a460f267005dcf6551959064b3238/src/node_snapshotable.cc#L187 Refs: #47458 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #47933 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced May 13, 2023
19 tasks
danielleadams pushed a commit
that referenced
this pull request
Jul 6, 2023
This should make it possible to reuse the BlobSerializer and the BlobDeserializer classes in SEAs to generate and parse the injected blob. This change also resolves this TODO: https://github.com/nodejs/node/blob/4f69aae6a04a460f267005dcf6551959064b3238/src/node_snapshotable.cc#L187 Refs: #47458 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #47933 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MoLow pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
This should make it possible to reuse the BlobSerializer and the BlobDeserializer classes in SEAs to generate and parse the injected blob. This change also resolves this TODO: https://github.com/nodejs/node/blob/4f69aae6a04a460f267005dcf6551959064b3238/src/node_snapshotable.cc#L187 Refs: nodejs#47458 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#47933 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it possible to reuse the
BlobSerializerand theBlobDeserializerclasses in SEAs to generate and parse the injectedblob.
This change also resolves this TODO:
node/src/node_snapshotable.cc
Line 187 in 4f69aae
Refs: #47458
Signed-off-by: Darshan Sen raisinten@gmail.com
cc @joyeecheung