Uh oh!
There was an error while loading. Please reload this page.
test: unskip negative-settimeout.any.js WPT - #47946
Merged
Merged
Conversation
nodejs-github-bot
commented
May 10, 2023
Collaborator
targos
approved these changes
May 10, 2023
nodejs-github-bot
commented
May 10, 2023
Collaborator
VoltrexKeyva
approved these changes
May 10, 2023
nodejs-github-bot
commented
May 10, 2023
Collaborator
24 tasks
lpinca
approved these changes
May 11, 2023
23 tasks
nodejs-github-bot
commented
May 12, 2023
Collaborator
Landed in 8244e6c |
targos pushed a commit
that referenced
this pull request
May 12, 2023
PR-URL: #47946 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced May 13, 2023
targos pushed a commit
that referenced
this pull request
May 15, 2023
PR-URL: #47946 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced May 16, 2023
danielleadams pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47946 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47946 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#47834 resolved the concurrency issues of wpt/test-timers so I believe this skip is no longer needed.