Skip to content

permission: remove unused function declaration - #47957

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:230511_permission_remove_restrictaccess
May 15, 2023
Merged

permission: remove unused function declaration#47957
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:230511_permission_remove_restrictaccess

Conversation

@deokjinkim

Copy link
Copy Markdown
Contributor

RestrictAccess() is declared, but it's not used.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 11, 2023
RestrictAccess() is declared, but it's not used.
@deokjinkim
deokjinkimforce-pushed the 230511_permission_remove_restrictaccess branch from a26a348 to 5befef2CompareMay 11, 2023 08:32
@deokjinkimdeokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@deokjinkimdeokjinkim added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 12, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@deokjinkimdeokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@deokjinkimdeokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 8cbc307 into nodejs:mainMay 15, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 8cbc307

targos pushed a commit that referenced this pull request May 15, 2023
RestrictAccess() is declared, but it's not used.
PR-URL: #47957
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@targostargos mentioned this pull request May 15, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
RestrictAccess() is declared, but it's not used.
PR-URL: #47957
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
RestrictAccess() is declared, but it's not used.
PR-URL: nodejs#47957
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@deokjinkim@nodejs-github-bot@lpinca@anonrig@cjihrig@XadillaX@tniessen@RafaelGSS@RaisinTen