Skip to content

esm: do not use 'beforeExit' on the main thread - #47964

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:beforeExit-main-thread
May 14, 2023
Merged

esm: do not use 'beforeExit' on the main thread#47964
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:beforeExit-main-thread

Conversation

@aduh95

@aduh95aduh95 commented May 11, 2023

Copy link
Copy Markdown
Contributor

Fixes: #47929

@nodejs-github-bot

nodejs-github-bot commented May 11, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels May 11, 2023
GeoffreyBooth
GeoffreyBooth approved these changes May 11, 2023
View reviewed changes
Comment threadlib/internal/modules/esm/hooks.js
@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2023
@nodejs-github-bot

nodejs-github-bot commented May 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51773/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2023
@nodejs-github-bot
nodejs-github-bot merged commit cdd20cf into nodejs:mainMay 14, 2023
@nodejs-github-bot

nodejs-github-bot commented May 14, 2023

Copy link
Copy Markdown
Collaborator

Landed in cdd20cf

@aduh95
aduh95 deleted the beforeExit-main-thread branch May 14, 2023 06:21
@MoLowMoLow mentioned this pull request May 14, 2023
Closed
targos pushed a commit that referenced this pull request May 14, 2023
@aduh95@targos
esm: do not use 'beforeExit' on the main thread
a7a7eab
PR-URL: #47964Fixes: #47929
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request May 15, 2023
@aduh95@targos
esm: do not use 'beforeExit' on the main thread
1ec640a
PR-URL: #47964Fixes: #47929
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targostargos mentioned this pull request May 15, 2023
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95@targos
esm: do not use 'beforeExit' on the main thread
a31ca4e
PR-URL: nodejs#47964Fixes: nodejs#47929
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targostargos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95@targos
esm: do not use 'beforeExit' on the main thread
8cab32a
PR-URL: #47964
Backport-PR-URL: #50669Fixes: #47929
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: do not use 'beforeExit' on the main thread
85678ab
PR-URL: nodejs/node#47964
Backport-PR-URL: nodejs/node#50669Fixes: nodejs/node#47929
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: do not use 'beforeExit' on the main thread
721b5d9
PR-URL: nodejs/node#47964
Backport-PR-URL: nodejs/node#50669Fixes: nodejs/node#47929
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@anonriganonriganonrig approved these changes
@MoLowMoLowMoLow approved these changes

Assignees

No one assigned

Labels

esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node 20.1.0 --loader seems trigger beforeExit when use await import

7 participants

@aduh95@nodejs-github-bot@GeoffreyBooth@anonrig@MoLow@targos@danielleadams