doc: update list of personal traits in CoC by zkat · Pull Request #4801 · nodejs/node

zkat · 2016-01-21T19:20:36Z

rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in.

We also received a request to do this in nodejs/inclusivity#82 so this should resolve that.

This PR would preferably also be merged into LTS, imo.

/cc @nodejs/inclusivity @nodejs/lts @nodejs/documentation

ghost · 2016-01-21T19:23:01Z

cc @Charlotteis

zkat · 2016-01-21T19:23:39Z

@sup yes, that is perfectly valid in English.

varjmes · 2016-01-21T19:24:58Z

I believe Rust adapted this from the Contributor Covenant so that might be worth including in the first sentence about adaptations?

varjmes · 2016-01-21T19:25:33Z

is this supposed to say characteristic in singular?

I think it works how it is, yeah.

Fishrock123 · 2016-01-21T19:25:44Z

LGTM. This isn't actually a policy change, so there's no reason for this to go to a CTC meeting imo.

varjmes · 2016-01-21T19:25:48Z

Thanks very much @zkat ✨

ghost · 2016-01-21T19:27:59Z

@Charlotteis @zkat ok thanks! wasn't sure

MylesBorins · 2016-01-21T19:42:02Z

lgtm... I especially like the inclusion of level of experience

benjamingr · 2016-01-21T19:43:20Z

Very nice update. I'm glad the org is taking this direction.

jasnell · 2016-01-21T19:47:42Z

LGTM

jasnell · 2016-01-21T19:54:32Z

I agree with @Fishrock123 ... there shouldn't be a need to put this on the meeting agenda. I'd give it another day tho before landing.

mscdex · 2016-01-21T20:57:46Z

Out of curiosity, why is there an explicit list of characteristics anyway, especially if it could just go on and on forever like this since it's possible for anyone to discriminate for any reason? Isn't "we are committed to providing a friendly, safe and welcoming environment for all" enough?

ChALkeR · 2016-01-21T21:00:30Z

LGTM

benjamingr · 2016-01-21T21:02:55Z

@mscdex well presumably, if someone feels excluded from participating because of one of those traits from the list - they might feel better if they know they are explicitly encouraged to participate.

Or something like that.

varjmes · 2016-01-21T21:07:29Z

if someone feels excluded from participating because of one of those traits from the list - they might feel better if they know they are explicitly encouraged to participate.

This is largely why I proposed this in the first place, yeah 😄

Qard · 2016-01-21T21:58:57Z

@mscdex Explicit is better than implicit. One might try to argue that the lack of inclusion of a particular form of bigotry in the list is validation that it's "okay" when it really is not.

Fishrock123 · 2016-01-22T18:52:24Z

Updates still LGTM

juliepagano · 2016-01-22T20:34:54Z

:lgtm: ✨

ashleygwilliams · 2016-01-22T20:37:25Z

hey @jasnell do we think we'll merge today or next week? just curious.

really proud of our community's response on this thread. go node ❤️ 😊

Fishrock123 · 2016-01-22T20:52:33Z

@ashleygwilliams I don't see why we wouldn't merge it today. Since @zkat is a collaborator we defer to her to do the actual merge unless otherwise noted. :)

rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> PR-URL: nodejs#4801Fixes: nodejs/inclusivity#82

rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> PR-URL: #4801Fixes: nodejs/inclusivity#82

zkat · 2016-01-22T21:38:17Z

Landed in master as of de0d35f 🎉

ashleygwilliams · 2016-01-22T21:45:42Z

💖

msikma · 2016-01-22T21:45:46Z

👍

chriseppstein · 2016-01-22T21:57:51Z

Suggestion: Change religion to religion or lack thereof.

zkat · 2016-01-22T22:11:47Z

@chriseppstein patches welcome 😁

nebrius · 2016-01-22T22:14:20Z

FWIW, we just added that language to the inclusivity CoC: nodejs/inclusivity#97. Thanks for the suggestion @chriseppstein!

jasnell · 2016-01-22T22:46:52Z

Closing because it landed :-) We'll definitely get this pulled back into the LTS... hopefully in the next round

thefourtheye · 2016-01-23T06:11:35Z

Would or any other characteristic have been better?

bnoordhuis · 2016-01-23T18:12:47Z

@zkat Can you keep lines in the commit log <= 72 columns next time? Thanks.

rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> PR-URL: #4801Fixes: nodejs/inclusivity#82

rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> PR-URL: nodejs#4801Fixes: nodejs/inclusivity#82

zkat added the doc Issues and PRs related to the documentations. label Jan 21, 2016

varjmes reviewed Jan 21, 2016
View reviewed changes

Fishrock123 added the meta Issues and PRs related to the general management of the project. label Jan 21, 2016

zkat force-pushed the gender-identity-patch branch from c17c6f3 to f31443bCompare January 21, 2016 19:26

zkat changed the title ~~doc: update list of personal trais in CoC~~doc: update list of personal traits in CoCJan 21, 2016

zkat force-pushed the gender-identity-patch branch from f31443b to d293d02Compare January 21, 2016 19:30

zkat force-pushed the gender-identity-patch branch from d293d02 to 974331dCompare January 21, 2016 20:38

jasnell added the lts-watch-v4.x label Jan 21, 2016

zkat force-pushed the gender-identity-patch branch from 974331d to de0d35fCompare January 22, 2016 21:34

jasnell closed this Jan 22, 2016

thefourtheye reviewed Jan 23, 2016
View reviewed changes

Comment threadCODE_OF_CONDUCT.md
thefourtheyeJan 23, 2016
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would or any other characteristic have been better?

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Jan 28, 2016

rvagg mentioned this pull request Feb 8, 2016
Release proposal: v5.5.1 (Stable) #5141
Closed

MylesBorins mentioned this pull request Feb 11, 2016
V4.3.1 proposal #5200
Merged

Uh oh!

Uh oh!

Conversation

zkat commented Jan 21, 2016

Uh oh!

ghost commented Jan 21, 2016

Uh oh!

zkat commented Jan 21, 2016

Uh oh!

varjmesJan 21, 2016

Choose a reason for hiding this comment

Uh oh!

zkatJan 21, 2016

Choose a reason for hiding this comment

Uh oh!

varjmes commented Jan 21, 2016

Uh oh!

Fishrock123 commented Jan 21, 2016

Uh oh!

varjmes commented Jan 21, 2016

Uh oh!

ghost commented Jan 21, 2016

Uh oh!

MylesBorins commented Jan 21, 2016

Uh oh!

benjamingr commented Jan 21, 2016

Uh oh!

jasnell commented Jan 21, 2016

Uh oh!

jasnell commented Jan 21, 2016

Uh oh!

mscdex commented Jan 21, 2016

Uh oh!

ChALkeR commented Jan 21, 2016

Uh oh!

benjamingr commented Jan 21, 2016

Uh oh!

varjmes commented Jan 21, 2016

Uh oh!

Qard commented Jan 21, 2016

Uh oh!

Fishrock123 commented Jan 22, 2016

Uh oh!

juliepagano commented Jan 22, 2016

Uh oh!

ashleygwilliams commented Jan 22, 2016

Uh oh!

Fishrock123 commented Jan 22, 2016

Uh oh!

zkat commented Jan 22, 2016

Uh oh!

ashleygwilliams commented Jan 22, 2016

Uh oh!

msikma commented Jan 22, 2016

Uh oh!

chriseppstein commented Jan 22, 2016

Uh oh!

zkat commented Jan 22, 2016

Uh oh!

nebrius commented Jan 22, 2016

Uh oh!

jasnell commented Jan 22, 2016

Uh oh!

thefourtheyeJan 23, 2016

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented Jan 23, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants