Skip to content

tools: open issue when update workflow fails - #48018

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
marco-ippolito:feat/issue--deps-update-fail
May 25, 2023
Merged

tools: open issue when update workflow fails#48018
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
marco-ippolito:feat/issue--deps-update-fail

Conversation

@marco-ippolito

Copy link
Copy Markdown
Member

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 15, 2023
@targos

Copy link
Copy Markdown
Member

Can you add a link to the failed run in the message?

@marco-ippolito

Copy link
Copy Markdown
MemberAuthor

Can you add a link to the failed run in the message?

Yes I'm figuring out how to

@marco-ippolito
marco-ippolitoforce-pushed the feat/issue--deps-update-fail branch from 3d7d0a4 to 3dcab0aCompareMay 15, 2023 14:16
@marco-ippolito
marco-ippolitoforce-pushed the feat/issue--deps-update-fail branch from 3dcab0a to 8df8fbcCompareMay 15, 2023 14:19
@marco-ippolito
marco-ippolito marked this pull request as ready for review May 15, 2023 18:02
Comment thread.github/ISSUE_TEMPLATE/failed-dep-update.md
Comment thread.github/workflows/tools.yml Outdated
@marco-ippolitomarco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 25, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48018
✔ Done loading data for nodejs/node/pull/48018
----------------------------------- PR info ------------------------------------
Title tools: open issue when update workflow fails (#48018)
Author Marco Ippolito (@marco-ippolito)
Branch marco-ippolito:feat/issue--deps-update-fail -> nodejs:main
Labels meta
Commits 3
- tools: open issue when update workflow fails
- feat: add job url
- fix: open issue only when scheduled
Committers 1
- Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/48018
Refs: https://github.com/nodejs/security-wg/issues/973
Reviewed-By: Richard Lau ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48018
Refs: https://github.com/nodejs/security-wg/issues/973
Reviewed-By: Richard Lau --------------------------------------------------------------------------------
ℹ This PR was created on Mon, 15 May 2023 12:48:43 GMT
✔ Approvals: 1
✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/48018#pullrequestreview-1436488602
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 48018
From https://github.com/nodejs/node
* branch refs/pull/48018/merge -> FETCH_HEAD
✔ Fetched commits as 442c35215f2b..f6acfa9a14e8
--------------------------------------------------------------------------------
[main d2fa33066e] tools: open issue when update workflow fails
Author: Marco Ippolito Date: Mon May 15 14:47:27 2023 +0200
2 files changed, 17 insertions(+)
create mode 100644 .github/ISSUE_TEMPLATE/failed-dep-update.yml
[main dea82e74ac] feat: add job url
Author: Marco Ippolito Date: Mon May 15 16:02:35 2023 +0200
3 files changed, 9 insertions(+), 8 deletions(-)
create mode 100644 .github/ISSUE_TEMPLATE/failed-dep-update.md
delete mode 100644 .github/ISSUE_TEMPLATE/failed-dep-update.yml
[main 04d4a5479d] fix: open issue only when scheduled
Author: Marco Ippolito Date: Tue May 16 10:15:55 2023 +0200
2 files changed, 2 insertions(+), 2 deletions(-)
rename .github/{ISSUE_TEMPLATE/failed-dep-update.md => FAILED_DEP_UPDATE_ISSUE_TEMPLATE.md} (100%)
✔ Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: open issue when update workflow fails

PR-URL: #48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau rlau@redhat.com

[detached HEAD af671790e2] tools: open issue when update workflow fails
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Mon May 15 14:47:27 2023 +0200
2 files changed, 17 insertions(+)
create mode 100644 .github/ISSUE_TEMPLATE/failed-dep-update.yml
Rebasing (3/6)
Rebasing (4/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
feat: add job url

PR-URL: #48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau rlau@redhat.com

[detached HEAD 6f763880de] feat: add job url
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Mon May 15 16:02:35 2023 +0200
3 files changed, 9 insertions(+), 8 deletions(-)
create mode 100644 .github/ISSUE_TEMPLATE/failed-dep-update.md
delete mode 100644 .github/ISSUE_TEMPLATE/failed-dep-update.yml
Rebasing (5/6)
Rebasing (6/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix: open issue only when scheduled

PR-URL: #48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau rlau@redhat.com

[detached HEAD 732bb54197] fix: open issue only when scheduled
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Tue May 16 10:15:55 2023 +0200
2 files changed, 2 insertions(+), 2 deletions(-)
rename .github/{ISSUE_TEMPLATE/failed-dep-update.md => FAILED_DEP_UPDATE_ISSUE_TEMPLATE.md} (100%)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5077383983

@marco-ippolitomarco-ippolito added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 25, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c488558 into nodejs:mainMay 25, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in c488558

targos pushed a commit that referenced this pull request May 30, 2023
PR-URL: #48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau <rlau@redhat.com>
@targostargos mentioned this pull request Jun 4, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau <rlau@redhat.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau <rlau@redhat.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau <rlau@redhat.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@marco-ippolito@nodejs-github-bot@targos@tniessen@UlisesGascon@richardlau