test_runner: display dot report as wide as the terminal width by rluvaton · Pull Request #48038 · nodejs/node

rluvaton · 2023-05-16T21:33:06Z

I had a problem with PR #47901 so recreating it

nodejs-github-bot · 2023-05-16T21:33:11Z

Review requested:

@nodejs/test_runner

Co-authored-by: Moshe Atlow <moshe@atlow.co.il>

nodejs-github-bot · 2023-05-19T09:04:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51876/

nodejs-github-bot · 2023-05-19T12:46:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51878/

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot · 2023-05-21T10:13:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51898/

nodejs-github-bot · 2023-05-21T11:41:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51899/

cjihrig · 2023-05-21T13:40:15Z

 yield 'X';
 }
- if ((type === 'test:fail' || type === 'test:pass') && ++count % 20 === 0) {
+ if ((type === 'test:fail' || type === 'test:pass') && ++count === columns) {


Could the ++count === columns be nested inside of the top level if? That way we only need to call getLineLength() once from there.

The need to call again is in case of resize of the terminal

Co-authored-by: cjihrig <cjihrig@gmail.com>

nodejs-github-bot · 2023-05-22T21:43:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51917/

nodejs-github-bot · 2023-05-23T03:37:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51919/

nodejs-github-bot · 2023-05-23T04:44:40Z

Landed in 7e0c12f

PR-URL: #48038 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: nodejs#48038 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

test_runner: display dot report as wide as the terminal width
c324ad8

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 16, 2023

rluvaton mentioned this pull request May 16, 2023
test: display dot report as wide as the terminal width #47901
Closed

MoLow reviewed May 17, 2023
View reviewed changes

Comment threadtest/fixtures/test-runner/output/dot_output_custom_columns.js Outdated

MoLow reviewed May 17, 2023
View reviewed changes

Comment threadtest/fixtures/test-runner/output/dot_output_custom_columns.js Outdated

MoLow reviewed May 19, 2023
View reviewed changes

Comment threadlib/internal/test_runner/reporter/dot.js Outdated

test_runner: add test and fix error
b47e380

MoLow reviewed May 19, 2023
View reviewed changes

Comment threadlib/internal/test_runner/reporter/dot.js Outdated

Update lib/internal/test_runner/reporter/dot.js
ae1906c
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>

MoLow approved these changes May 19, 2023
View reviewed changes

MoLow added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 19, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 19, 2023

aduh95 reviewed May 19, 2023
View reviewed changes

Comment threadtest/fixtures/test-runner/output/dot_output_custom_columns.js Outdated

github-actionsBot mentioned this pull request May 20, 2023
CI Reliability 2023-05-20 nodejs/reliability#571
Open
19 tasks

Update test/fixtures/test-runner/output/dot_output_custom_columns.js
b991fd2
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

github-actionsBot mentioned this pull request May 21, 2023
CI Reliability 2023-05-21 nodejs/reliability#572
Open
19 tasks

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2023

cjihrig reviewed May 21, 2023
View reviewed changes

github-actionsBot mentioned this pull request May 22, 2023
CI Reliability 2023-05-22 nodejs/reliability#573
Open
16 tasks

rluvatonand others added 2 commits May 22, 2023 07:56

Update test/fixtures/test-runner/output/dot_output_custom_columns.js
d38e661
Co-authored-by: cjihrig <cjihrig@gmail.com>

Update test/fixtures/test-runner/output/dot_output_custom_columns.js
ef8cec7
Co-authored-by: cjihrig <cjihrig@gmail.com>

MoLow requested a review from cjihrig May 22, 2023 15:51

cjihrig approved these changes May 22, 2023
View reviewed changes

MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 22, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2023

github-actionsBot mentioned this pull request May 23, 2023
CI Reliability 2023-05-23 nodejs/reliability#574
Open
22 tasks

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023

nodejs-github-bot merged commit 7e0c12f into nodejs:mainMay 23, 2023

targos pushed a commit that referenced this pull request May 30, 2023
test_runner: display dot report as wide as the terminal width
23d310b
PR-URL: #48038 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

github-actionsBot mentioned this pull request May 31, 2023
CI Reliability 2023-05-31 nodejs/reliability#582
Open
22 tasks

targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged

rluvaton deleted the display-dot-test-report-as-wide-as-the-terminal branch June 28, 2023 17:40

danielleadams pushed a commit that referenced this pull request Jul 6, 2023
test_runner: display dot report as wide as the terminal width
f8cf353
PR-URL: #48038 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
test_runner: display dot report as wide as the terminal width
e0d0b19
PR-URL: nodejs#48038 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test_runner: display dot report as wide as the terminal width
7af4903
PR-URL: nodejs#48038 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test_runner: display dot report as wide as the terminal width
ac4359d
PR-URL: nodejs#48038 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Uh oh!

Uh oh!

Conversation

rluvaton commented May 16, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented May 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented May 19, 2023

Uh oh!

nodejs-github-bot commented May 19, 2023

Uh oh!

Uh oh!

nodejs-github-bot commented May 21, 2023

Uh oh!

nodejs-github-bot commented May 21, 2023

Uh oh!

cjihrigMay 21, 2023

Choose a reason for hiding this comment

Uh oh!

rluvatonMay 22, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented May 22, 2023

Uh oh!

nodejs-github-bot commented May 23, 2023

Uh oh!

nodejs-github-bot commented May 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rluvaton commented May 16, 2023•
edited
Loading