Skip to content

deps: add loong64 config into openssl gypi - #48043

Closed
shipujin wants to merge 1 commit into
nodejs:mainfrom
shipujin:loong64-dev
Closed

deps: add loong64 config into openssl gypi#48043
shipujin wants to merge 1 commit into
nodejs:mainfrom
shipujin:loong64-dev

Conversation

@shipujin

@shipujinshipujin commented May 17, 2023

Copy link
Copy Markdown
Member

add loong64 config into openssl

@nodejs-github-bot

nodejs-github-bot commented May 17, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels May 17, 2023
@shipujin

shipujin commented Jun 9, 2023

Copy link
Copy Markdown
MemberAuthor

Update

@mhdawson

mhdawson commented Jun 12, 2023

Copy link
Copy Markdown
Member

@shipujin I assume that the only non-generated changes that are the ones in the gypi files?

@mhdawson

mhdawson commented Jun 12, 2023

Copy link
Copy Markdown
Member

I guess that last question did not make sense if all of the .h files are also manually updated which I think is now the case.

It this just what is missing to get loong64 working. I already see that there are filex in - https://github.com/nodejs/node/tree/main/deps/openssl/config/archs/linux64-loongarch64/no-asm

@shipujin

shipujin commented Jun 13, 2023

Copy link
Copy Markdown
MemberAuthor

@shipujin I assume that the only non-generated changes that are the ones in the gypi files?

Yes, once the *gypi file is modified , nodejs can be built using openssl-no-asm in the loong64 environment.

thx~

@shipujin

shipujin commented Jun 13, 2023

Copy link
Copy Markdown
MemberAuthor

I guess that last question did not make sense if all of the .h files are also manually updated which I think is now the case.

It this just what is missing to get loong64 working. I already see that there are filex in - https://github.com/nodejs/node/tree/main/deps/openssl/config/archs/linux64-loongarch64/no-asm

Yes

thx~

@mhdawsonmhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2023
mhdawson
mhdawson approved these changes Jun 28, 2023
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52546/

@nodejs-github-bot

nodejs-github-bot commented Jun 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52559/

mhdawson pushed a commit that referenced this pull request Jun 29, 2023
@shipujin@mhdawson
deps: add loong64 config into openssl gypi
9664e66
PR-URL: #48043
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mhdawson

mhdawson commented Jun 29, 2023

Copy link
Copy Markdown
Member

Landed in 9664e66

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@shipujin@RafaelGSS
deps: add loong64 config into openssl gypi
1b2b930
PR-URL: #48043
Reviewed-By: Michael Dawson <midawson@redhat.com>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@shipujin@Ceres6
deps: add loong64 config into openssl gypi
ccf91af
PR-URL: nodejs#48043
Reviewed-By: Michael Dawson <midawson@redhat.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@shipujin@Ceres6
deps: add loong64 config into openssl gypi
b22318c
PR-URL: nodejs#48043
Reviewed-By: Michael Dawson <midawson@redhat.com>
@shipujinshipujin mentioned this pull request Aug 16, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
Shi Pujin@ruyadorno
deps: add loong64 config into openssl gypi
3be5335
Backport-PR-URL: #49192
PR-URL: #48043
Reviewed-By: Michael Dawson midawson@redhat.com
@ruyadornoruyadorno mentioned this pull request Sep 1, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependenciesPull requests that update a dependency file.needs-ciPRs that need a full CI run.opensslIssues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shipujin@nodejs-github-bot@mhdawson@ruyadorno