Skip to content

test: test streambase already has a consumer - #48059

Closed
MrJithil wants to merge 1 commit into
nodejs:mainfrom
MrJithil:improve-webstreams-adapters-coverage
Closed

test: test streambase already has a consumer#48059
MrJithil wants to merge 1 commit into
nodejs:mainfrom
MrJithil:improve-webstreams-adapters-coverage

Conversation

@MrJithil

@MrJithilMrJithil commented May 18, 2023•
edited
Loading

Copy link
Copy Markdown
Member
  • test streambase already has a consumer
  • newStreamDuplexFromReadableWritablePair doesn't have a readable prop
  • newStreamDuplexFromReadableWritablePair doesn't have a writable prop

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 18, 2023
@MrJithil
MrJithilforce-pushed the improve-webstreams-adapters-coverage branch from ae09e10 to d0aeccfCompareMay 18, 2023 13:59
@MrJithil
MrJithilforce-pushed the improve-webstreams-adapters-coverage branch from e38084c to fed96f5CompareOctober 7, 2023 02:03
aduh95
aduh95 reviewed Oct 10, 2023
View reviewed changes
Comment threadtest/parallel/test-whatwg-webstreams-adapters-to-readablewritablepair.js Outdated
Comment threadtest/parallel/test-whatwg-webstreams-adapters-to-streamduplex.js Outdated
Comment threadtest/parallel/test-whatwg-webstreams-adapters-to-streamduplex.js Outdated
Comment threadtest/parallel/test-whatwg-webstreams-adapters-streambase.js Outdated
Comment threadtest/parallel/test-whatwg-webstreams-adapters-streambase.js Outdated
@MrJithil
MrJithilforce-pushed the improve-webstreams-adapters-coverage branch from fed96f5 to f451c28CompareOctober 11, 2023 08:59
@MrJithil
MrJithil requested a review from aduh95October 11, 2023 09:00
aduh95
aduh95 reviewed Oct 11, 2023
View reviewed changes
Comment threadtest/parallel/test-whatwg-webstreams-adapters-streambase.js Outdated
@MrJithil
MrJithilforce-pushed the improve-webstreams-adapters-coverage branch from f451c28 to 9c4697cCompareOctober 11, 2023 09:21
@MrJithil
MrJithil requested a review from aduh95October 11, 2023 09:21
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 11, 2023
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Oct 11, 2023
@github-actions

github-actionsBot commented Oct 11, 2023

Copy link
Copy Markdown
Contributor
Failed to start CI
node:internal/modules/cjs/loader:1028
const err = new Error(message);
^

Error: Cannot find module 'call-bind'

Require stack:
  • /opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js
    
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1028:15)
    
at Function.Module._load (node:internal/modules/cjs/loader:873:27)
    
at Module.require (node:internal/modules/cjs/loader:1100:19)
    
at require (node:internal/modules/cjs/helpers:119:18)
    
at Object. (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js:4:16)
    
at Module._compile (node:internal/modules/cjs/loader:1198:14)
    
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    
at Module.load (node:internal/modules/cjs/loader:1076:32)
    
at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    
at ModuleWrap. (node:internal/modules/esm/translators:169:29) {
    
code: 'MODULE_NOT_FOUND',
    
requireStack: [
    
'/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js'
    
]
    
}
https://github.com/nodejs/node/actions/runs/6480821911

@aduh95aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 11, 2023
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@MrJithil
MrJithilforce-pushed the improve-webstreams-adapters-coverage branch from 9c4697c to 638a73bCompareNovember 3, 2023 10:05
@MrJithil
test: test streambase has already has a consumer
6ade593
test: test streambase has already has a consumer
@MrJithil
MrJithilforce-pushed the improve-webstreams-adapters-coverage branch from 638a73b to 6ade593CompareNovember 3, 2023 10:07
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Nov 4, 2023
Open
14 tasks
This was referenced Nov 5, 2023
Open
Open
Open
Open
Open
Open
@MrJithilMrJithil added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2023
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55570/

MrJithil added a commit that referenced this pull request Nov 14, 2023
@MrJithil
test: test streambase has already has a consumer
eb46e09
test: test streambase has already has a consumer
PR-URL: #48059
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MrJithil

MrJithil commented Nov 14, 2023

Copy link
Copy Markdown
MemberAuthor

Landed in eb46e09

targos pushed a commit that referenced this pull request Nov 23, 2023
@MrJithil@targos
test: test streambase has already has a consumer
377dede
test: test streambase has already has a consumer
PR-URL: #48059
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Nov 28, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@MrJithil@UlisesGascon
test: test streambase has already has a consumer
b67665f
test: test streambase has already has a consumer
PR-URL: #48059
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@MrJithil@UlisesGascon
test: test streambase has already has a consumer
49e5f47
test: test streambase has already has a consumer
PR-URL: #48059
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MrJithil@nodejs-github-bot@jasnell@aduh95