Uh oh!
There was an error while loading. Please reload this page.
tools: fix zconf.h path - #48089
Merged
Merged
Conversation
Use the `DEPS_DIR` variable to build the path instead of hardcoding it.
aduh95
approved these changes
May 20, 2023
tniessen
approved these changes
May 20, 2023
Contributor
Fast-track has been requested by @lpinca. Please 👍 to approve. |
nodejs-github-bot
commented
May 21, 2023
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/48089 ✔ Done loading data for nodejs/node/pull/48089 ----------------------------------- PR info ------------------------------------ Title tools: fix zconf.h path (#48089) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch lpinca:use/deps-dir-variable -> nodejs:main Labels tools, fast-track Commits 1 - tools: fix zconf.h path Committers 1 - Luigi Pinca PR-URL: https://github.com/nodejs/node/pull/48089 Reviewed-By: Antoine du Hamel Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48089 Reviewed-By: Antoine du Hamel Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 20 May 2023 16:21:00 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/48089#pullrequestreview-1435429205 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/48089#pullrequestreview-1435449457 ℹ This PR is being fast-tracked ✘ This PR needs to wait 34 more hours to land (or 0 hours if there are 2 more approvals (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5036055133 |
marco-ippolito
approved these changes
May 21, 2023
nodejs-github-bot
commented
May 21, 2023
Collaborator
Landed in 95d2429 |
targos pushed a commit
that referenced
this pull request
May 30, 2023
Use the `DEPS_DIR` variable to build the path instead of hardcoding it. PR-URL: #48089 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jul 6, 2023
Use the `DEPS_DIR` variable to build the path instead of hardcoding it. PR-URL: #48089 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
MoLow pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Use the `DEPS_DIR` variable to build the path instead of hardcoding it. PR-URL: nodejs#48089 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Ceres6 pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Use the `DEPS_DIR` variable to build the path instead of hardcoding it. PR-URL: nodejs#48089 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Ceres6 pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Use the `DEPS_DIR` variable to build the path instead of hardcoding it. PR-URL: nodejs#48089 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
DEPS_DIRvariable to build the path instead of hardcoding it.Extracted from #48054.