Skip to content

test: mark test-tick-processor flaky - #4809

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:mark-test-tick-processor
Closed

test: mark test-tick-processor flaky#4809
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:mark-test-tick-processor

Conversation

@Trott

@TrottTrott commented Jan 21, 2016

Copy link
Copy Markdown
Member

Ref: #4427

Recent sample failures:

@TrottTrott added v8 engine Issues and PRs related to the V8 dependency. test Issues and PRs related to the tests. labels Jan 21, 2016
@jasnell

jasnell commented Jan 22, 2016

Copy link
Copy Markdown
Member

@Trott ... is this flakiness due to recent changes or would this need to be marked in LTS also?

@Trott

Trott commented Jan 22, 2016

Copy link
Copy Markdown
MemberAuthor

@jasnell This should apply to LTS as well.

@Trott

Trott commented Jan 24, 2016

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/1360/

/cc @nodejs/testing (looking for an LGTM on this, seems like it should be non-controversial)

@jasnell

jasnell commented Jan 24, 2016

Copy link
Copy Markdown
Member

LGTM
On Jan 23, 2016 11:35 PM, "Rich Trott" notifications@github.com wrote:

CI: https://ci.nodejs.org/job/node-test-pull-request/1360/

/cc @nodejs/testing https://github.com/orgs/nodejs/teams/testing
(looking for an LGTM on this, seems like it should be non-controversial)

—
Reply to this email directly or view it on GitHub
#4809 (comment).

@jbergstroem

jbergstroem commented Jan 24, 2016

Copy link
Copy Markdown
Member

LGTM 😢

@cjihrig

cjihrig commented Jan 24, 2016

Copy link
Copy Markdown
Contributor

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jan 25, 2016
@Trott
test: mark test-tick-processor flaky
c6d29cb
PR-URL: nodejs#4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#4427
@Trott

Trott commented Jan 25, 2016

Copy link
Copy Markdown
MemberAuthor

Landed in c6d29cb

@TrottTrott closed this Jan 25, 2016
rvagg pushed a commit that referenced this pull request Jan 25, 2016
@Trott@rvagg
test: mark test-tick-processor flaky
ae9a8cd
PR-URL: #4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: #4427
benjamingr pushed a commit to benjamingr/io.js that referenced this pull request Jan 27, 2016
@Trott@benjamingr
test: mark test-tick-processor flaky
0e16694
PR-URL: nodejs#4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#4427
@jasnell

jasnell commented Jan 27, 2016

Copy link
Copy Markdown
Member

@Trott .. I marked this lts-watch for v4.. can you confirm that tho? Not sure when this went flaky

@Trott

Trott commented Jan 28, 2016

Copy link
Copy Markdown
MemberAuthor

@jasnell I ran a stress test against the v4.x branch and the test is flaky there, so yes, confirmed. https://ci.nodejs.org/job/node-stress-single-test/377/nodes=win2008r2/console

@rvaggrvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
@TrottMyles Borins
test: mark test-tick-processor flaky
78449b6
PR-URL: #4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: #4427
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@TrottMyles Borins
test: mark test-tick-processor flaky
0a44e6a
PR-URL: #4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: #4427
@MylesBorinsMylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@TrottMyles Borins
test: mark test-tick-processor flaky
183bdef
PR-URL: #4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: #4427
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@TrottMichael Scovetta
test: mark test-tick-processor flaky
3e1caee
PR-URL: nodejs#4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#4427
@Trott
Trott deleted the mark-test-tick-processor branch January 13, 2022 22:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@jasnell@jbergstroem@cjihrig@MylesBorins