Skip to content

test_runner: fix test deserialize edge cases - #48106

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-test-deserialize
May 23, 2023
Merged

test_runner: fix test deserialize edge cases#48106
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-test-deserialize

Conversation

@MoLow

@MoLowMoLow commented May 21, 2023

Copy link
Copy Markdown
Member

Fixes: #48103

@nodejs-github-bot

nodejs-github-bot commented May 21, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 21, 2023
@MoLow
MoLow requested a review from cjihrigMay 22, 2023 15:51
cjihrig
cjihrig approved these changes May 22, 2023
View reviewed changes
Comment threadlib/internal/test_runner/runner.js Outdated
Comment threadtest/parallel/test-runner-v8-deserializer.mjs Outdated
Comment threadtest/parallel/test-runner-v8-deserializer.mjs Outdated
Comment threadtest/parallel/test-runner-v8-deserializer.mjs Outdated
Comment threadtest/parallel/test-runner-v8-deserializer.mjs Outdated
Comment threadtest/parallel/test-runner-v8-deserializer.mjs Outdated
Comment threadlib/internal/test_runner/runner.js Outdated
Comment threadlib/internal/test_runner/runner.js Outdated
@cjihrig

cjihrig commented May 22, 2023

Copy link
Copy Markdown
Contributor

It might be worth adding a note/label on the original PR that moved to V8 serialization that this PR should be backported with it.

@MoLow
MoLowforce-pushed the fix-test-deserialize branch from 1b32632 to e669180CompareMay 23, 2023 05:52
@MoLowMoLow mentioned this pull request May 23, 2023
Merged
@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2023
@nodejs-github-bot

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51921/

@nodejs-github-bot

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51923/

@nodejs-github-bot

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51924/

@nodejs-github-bot

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51938/

@MoLow
MoLow requested a review from benjamingrMay 23, 2023 17:01
@MoLowMoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2023
@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f0e70ee into nodejs:mainMay 23, 2023
@nodejs-github-bot

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in f0e70ee

@MoLow
MoLow deleted the fix-test-deserialize branch May 23, 2023 21:03
This was referenced May 24, 2023
Open
Open
Open
Open
Open
Open
Open
targos pushed a commit that referenced this pull request May 30, 2023
@MoLow@targos
test_runner: fix test deserialize edge cases
027c531
PR-URL: #48106Fixes: #48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 31, 2023
Open
22 tasks
@targostargos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow@danielleadams
test_runner: fix test deserialize edge cases
d18b61b
PR-URL: #48106Fixes: #48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
test_runner: fix test deserialize edge cases
47602fe
PR-URL: nodejs#48106Fixes: nodejs#48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow@Ceres6
test_runner: fix test deserialize edge cases
697b6bd
PR-URL: nodejs#48106Fixes: nodejs#48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow@Ceres6
test_runner: fix test deserialize edge cases
84b2e49
PR-URL: nodejs#48106Fixes: nodejs#48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test runner v8 serialization fails

4 participants

@MoLow@nodejs-github-bot@cjihrig@benjamingr