Skip to content

[v18.x backport] deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64 - #48135

Closed
shipujin wants to merge 1 commit into
nodejs:v18.x-stagingfrom
shipujin:loong64-dev-v18.x-staging
Closed

[v18.x backport] deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64#48135
shipujin wants to merge 1 commit into
nodejs:v18.x-stagingfrom
shipujin:loong64-dev-v18.x-staging

Conversation

@shipujin

@shipujinshipujin commented May 23, 2023

Copy link
Copy Markdown
Member

Add linux64-loongarch64 into Makefile
And run make

PR-URL: #46401
Backport-PR-URL: #48135
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Michael Dawson midawson@redhat.com

@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. v18.x labels May 23, 2023
@shipujin

Copy link
Copy Markdown
MemberAuthor

Add linux64-loongarch64 into Makefile
And run make

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51993/

@shipujin
shipujinforce-pushed the loong64-dev-v18.x-staging branch from 2bb7539 to 8f8bafcCompareJune 26, 2023 08:24
@shipujin

Copy link
Copy Markdown
MemberAuthor

Update

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@shipujin

Copy link
Copy Markdown
MemberAuthor

Hi @danielleadams ,I have verified and updated this patch on my computer. Could you please help review this patch.
thx~

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52723/

@Trott

Trott commented Aug 3, 2023

Copy link
Copy Markdown
Member

@ruyadorno Is this something that might end up in the next 18.x release. (According to nodejs/Release#737, you're doing the 18.x release for August 2023. Apologies if I'm doing things wrong and you're not the person to ping!)

ruyadorno pushed a commit that referenced this pull request Aug 16, 2023
Add linux64-loongarch64 into Makefile
And run make
PR-URL: #46401
Backport-PR-URL: #48135
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Michael Dawson midawson@redhat.com
@ruyadorno

Copy link
Copy Markdown
Member

Landed in f4617a4

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency file.needs-ciPRs that need a full CI run.opensslIssues and PRs related to the OpenSSL dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@shipujin@nodejs-github-bot@Trott@ruyadorno