Skip to content

test_runner: apply runOnly on suites - #48279

Closed
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:fix-suite-children-only
Closed

test_runner: apply runOnly on suites#48279
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:fix-suite-children-only

Conversation

@MoLow

@MoLowMoLow commented Jun 1, 2023

Copy link
Copy Markdown
Member

Fixes: #47937

@MoLow
MoLow requested review from benjamingr and cjihrigJune 1, 2023 10:06
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jun 1, 2023
@MoLow

MoLow commented Jun 3, 2023

Copy link
Copy Markdown
MemberAuthor

ping @nodejs/test_runner can someone take a look?

@MoLowMoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 4, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52080/

MoLow added a commit that referenced this pull request Jun 4, 2023
@MoLow
test_runner: apply runOnly on suites
5c27cc2
PR-URL: #48279Fixes: #47937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MoLow

MoLow commented Jun 4, 2023

Copy link
Copy Markdown
MemberAuthor

Landed in 5c27cc2

@MoLowMoLow closed this Jun 4, 2023
@MoLow
MoLow deleted the fix-suite-children-only branch June 4, 2023 21:06
@github-actionsgithub-actionsBot mentioned this pull request Jun 5, 2023
Open
30 tasks
targos pushed a commit that referenced this pull request Jun 5, 2023
@MoLow@targos
test_runner: apply runOnly on suites
44411fc
PR-URL: #48279Fixes: #47937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targostargos mentioned this pull request Jun 5, 2023
Merged
This was referenced Jun 6, 2023
Open
Open
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow@danielleadams
test_runner: apply runOnly on suites
45c1ea8
PR-URL: #48279Fixes: #47937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
test_runner: apply runOnly on suites
2262653
PR-URL: nodejs#48279Fixes: nodejs#47937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow@Ceres6
test_runner: apply runOnly on suites
cf0c2f3
PR-URL: nodejs#48279Fixes: nodejs#47937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow@Ceres6
test_runner: apply runOnly on suites
7d68a89
PR-URL: nodejs#48279Fixes: nodejs#47937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@cjihrigcjihrigcjihrig approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

it.only inside describe.only run all other its as well

6 participants

@MoLow@nodejs-github-bot@ljharb@benjamingr@cjihrig@aduh95