Uh oh!
There was an error while loading. Please reload this page.
benchmark: add crypto.create*Key - #48284
Merged
Merged
Conversation
panva
commented
Jun 1, 2023
MemberAuthor
cc @nodejs/crypto |
tniessen
approved these changes
Jun 2, 2023
Uh oh!
There was an error while loading. Please reload this page.
tniessen
commented
Jun 2, 2023
Member
cc @nodejs/performance |
lpinca
approved these changes
Jun 2, 2023
anonrig
approved these changes
Jun 2, 2023
Uh oh!
There was an error while loading. Please reload this page.
RafaelGSS
approved these changes
Jun 2, 2023
H4ad
approved these changes
Jun 2, 2023
jasnell
approved these changes
Jun 3, 2023
panvaforce-pushed
the
crypto-bench-createKey
branch
from
June 5, 2023 07:49
a3647aa to
2b9eabaCompareanonrig
approved these changes
Jun 5, 2023
nodejs-github-bot
commented
Jun 5, 2023
Collaborator
Landed in 6327d45 |
RafaelGSS pushed a commit
that referenced
this pull request
Jul 3, 2023
PR-URL: #48284 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Ceres6 pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48284 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6 pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48284 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit
that referenced
this pull request
Aug 29, 2023
PR-URL: #48284 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
crypto.createPrivateKeyandcrypto.createPublicKeybenchmarks for pem, der, and jwk inputs using rsa, ec, and ed25519 key fixtures.