Skip to content

Revert "tools: open issue when update workflow fails" - #48312

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:revert/open-issue-dep-update-fail
Jun 3, 2023
Merged

Revert "tools: open issue when update workflow fails"#48312
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:revert/open-issue-dep-update-fail

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Jun 3, 2023

Copy link
Copy Markdown
Member

This reverts commit c488558.
the action creates an issue that dep update failed: #48309 but actually worked #48308, while other jobs failed

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 3, 2023
@marco-ippolitomarco-ippolito added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 3, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @marco-ippolito. Please 👍 to approve.

@tniessen

Copy link
Copy Markdown
Member

Why did the step run at all? #48308 was opened by a manual run, wasn't it?

@marco-ippolito

Copy link
Copy Markdown
MemberAuthor

Why did the step run at all? #48308 was opened by a manual run, wasn't it?

Yes it was triggered by @anonrig, there is something wrong in the action, reverting this until we figure it out before it starts opening like 20 issues this sunday

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 3, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 3, 2023
@nodejs-github-bot
nodejs-github-bot merged commit fdf8ecd into nodejs:mainJun 3, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in fdf8ecd

targos pushed a commit that referenced this pull request Jun 4, 2023
This reverts commit c488558.
PR-URL: #48312
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request Jun 4, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
This reverts commit c488558.
PR-URL: #48312
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
This reverts commit c488558.
PR-URL: nodejs#48312
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
This reverts commit c488558.
PR-URL: nodejs#48312
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
This reverts commit c488558.
PR-URL: nodejs#48312
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@marco-ippolito@nodejs-github-bot@tniessen@richardlau@aduh95@Mesteery