Skip to content

test: add missing <algorithm> include for std::find - #48380

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
thesamesam:gcc14
Jun 9, 2023
Merged

test: add missing <algorithm> include for std::find#48380
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
thesamesam:gcc14

Conversation

@thesamesam

@thesamesamthesamesam commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

GCC 14 drops some transitive includes within libstdc++. Explicitly include for std::find.

Signed-off-by: Sam James sam@gentoo.org

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 7, 2023
@thesamesam

thesamesam commented Jun 7, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Sorry, this is identical to #48330 - I was playing with some github tooling to update local forks and messed it up (and it deleted the fork).

Apologies for the hassle folks.

LiviaMedeiros
LiviaMedeiros reviewed Jun 7, 2023
View reviewed changes
Comment threadtest/embedding/embedtest.cc Outdated
@thesamesam
test: add missing <algorithm> include for std::find
f02cf6f
GCC 14 drops some transitive includes within libstdc++.
Explicitly include <algorithm> for std::find.
Signed-off-by: Sam James <sam@gentoo.org>
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52150/

@lpincalpinca added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 8, 2023
@debadree25debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 8, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ad0bbaf into nodejs:mainJun 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in ad0bbaf

@thesamesam
thesamesam deleted the gcc14 branch June 10, 2023 04:48
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@thesamesam@RafaelGSS
test: add missing <algorithm> include for std::find
77cb1ee
GCC 14 drops some transitive includes within libstdc++.
Explicitly include <algorithm> for std::find.
Signed-off-by: Sam James <sam@gentoo.org>
PR-URL: #48380
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@thesamesam@Ceres6
test: add missing <algorithm> include for std::find
115d4df
GCC 14 drops some transitive includes within libstdc++.
Explicitly include <algorithm> for std::find.
Signed-off-by: Sam James <sam@gentoo.org>
PR-URL: nodejs#48380
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@thesamesam@Ceres6
test: add missing <algorithm> include for std::find
2f1654f
GCC 14 drops some transitive includes within libstdc++.
Explicitly include <algorithm> for std::find.
Signed-off-by: Sam James <sam@gentoo.org>
PR-URL: nodejs#48380
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
@thesamesam@ruyadorno
test: add missing <algorithm> include for std::find
23721c2
GCC 14 drops some transitive includes within libstdc++.
Explicitly include <algorithm> for std::find.
Signed-off-by: Sam James <sam@gentoo.org>
PR-URL: #48380
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
@ruyadornoruyadorno mentioned this pull request Aug 29, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
@thesamesam@ruyadorno
test: add missing <algorithm> include for std::find
27a4bc7
GCC 14 drops some transitive includes within libstdc++.
Explicitly include <algorithm> for std::find.
Signed-off-by: Sam James <sam@gentoo.org>
PR-URL: #48380
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiviaMedeirosLiviaMedeirosLiviaMedeiros approved these changes
@lpincalpincalpinca approved these changes
@KhafraDevKhafraDevKhafraDev approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thesamesam@nodejs-github-bot@lpinca@KhafraDev@LiviaMedeiros@debadree25