Skip to content

tools: update eslint-plugin-jsdoc - #48393

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:eslint
Jun 9, 2023
Merged

tools: update eslint-plugin-jsdoc#48393
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:eslint

Conversation

@richardlau

@richardlaurichardlau commented Jun 8, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Run a subset of tools/dep_updaters/update-eslint.sh to update eslint-plugin-jsdoc to get rid of a spurious ENOENT error when running the linter.

Fixes: #48374

Ran this subset to update -- the script as a whole will exit early because eslint itself hasn't been updated:

node/tools/dep_updaters/update-eslint.sh

Lines 52 to 71 in f2670a6

(
cd node_modules/eslint
"$NODE""$NPM" install \
--ignore-scripts \
--install-links=false \
--no-bin-links \
--no-save \
--omit=dev \
--omit=peer \
eslint-plugin-jsdoc \
eslint-plugin-markdown \
@babel/core \
@babel/eslint-parser \
@babel/plugin-syntax-import-assertions
)
# Use dmn to remove some unneeded files.
"$NODE""$NPM"exec --package=dmn@2.2.2 --yes -- dmn -f clean
# TODO: Get this into dmn.
find node_modules -name .package-lock.json -exec rm {} \;
find node_modules -name 'README*' -exec rm {} \;

@richardlau
tools: update eslint-plugin-jsdoc
b089ef2
Run a subset of `tools/dep_updaters/update-eslint.sh` to update
`eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
running the linter.
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 8, 2023
@richardlaurichardlau mentioned this pull request Jun 8, 2023
Closed
@richardlaurichardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 8, 2023
@aduh95aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 8, 2023
@github-actions

github-actionsBot commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit da1c9e3 into nodejs:mainJun 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in da1c9e3

@richardlau
richardlau deleted the eslint branch June 9, 2023 07:38
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@richardlau@RafaelGSS
tools: update eslint-plugin-jsdoc
8009e2c
Run a subset of `tools/dep_updaters/update-eslint.sh` to update
`eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
running the linter.
PR-URL: #48393Fixes: #48374
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@richardlau@Ceres6
tools: update eslint-plugin-jsdoc
0ae0f5b
Run a subset of `tools/dep_updaters/update-eslint.sh` to update
`eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
running the linter.
PR-URL: nodejs#48393Fixes: nodejs#48374
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@richardlau@Ceres6
tools: update eslint-plugin-jsdoc
121d470
Run a subset of `tools/dep_updaters/update-eslint.sh` to update
`eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
running the linter.
PR-URL: nodejs#48393Fixes: nodejs#48374
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
@richardlau@ruyadorno
tools: update eslint-plugin-jsdoc
e278634
Run a subset of `tools/dep_updaters/update-eslint.sh` to update
`eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
running the linter.
PR-URL: #48393Fixes: #48374
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@ruyadornoruyadorno mentioned this pull request Aug 29, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
@richardlau@ruyadorno
tools: update eslint-plugin-jsdoc
590a072
Run a subset of `tools/dep_updaters/update-eslint.sh` to update
`eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
running the linter.
PR-URL: #48393Fixes: #48374
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@MoLowMoLowMoLow approved these changes
@aduh95aduh95aduh95 approved these changes
+2 more reviewers
@debadree25debadree25debadree25 approved these changes
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ENOENT running JS linter

7 participants

@richardlau@nodejs-github-bot@lpinca@MoLow@aduh95@debadree25@VoltrexKeyva