Skip to content

test_runner: make --test-name-pattern recursive - #48401

Closed
MoLow wants to merge 2 commits into
nodejs:mainfrom
MoLow:test-runner-arrows
Closed

test_runner: make --test-name-pattern recursive#48401
MoLow wants to merge 2 commits into
nodejs:mainfrom
MoLow:test-runner-arrows

Conversation

@MoLow

@MoLowMoLow commented Jun 9, 2023

Copy link
Copy Markdown
Member

@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jun 9, 2023
benjamingr
benjamingr reviewed Jun 9, 2023
View reviewed changes
Comment threadtest/common/index.js Outdated
MoLow added 2 commits June 11, 2023 18:34
@MoLow
test: allow using Flags: with spaces
f26b357
@MoLow
test_runner: suppprt passing nested test name pattern
2f36be3
accept a name parretn with a path to a test with ">" as a separator
@MoLow
MoLowforce-pushed the test-runner-arrows branch from a6d369a to 2f36be3CompareJune 11, 2023 15:42
@MoLow

MoLow commented Jun 11, 2023

Copy link
Copy Markdown
MemberAuthor

this seems a little more complicated than I thought - when looking deeper than a single level, closing for now

@MoLowMoLow closed this Jun 11, 2023
@MoLow
MoLow deleted the test-runner-arrows branch June 11, 2023 15:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr left review comments

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test runner should allow specific subtest filtering, via --test-name-pattern or otherwise

3 participants

@MoLow@nodejs-github-bot@benjamingr