Uh oh!
There was an error while loading. Please reload this page.
Add "bun" export condition to common export conditions - #48407
Conversation
nodejs-github-bot
commented
Jun 9, 2023
Review requested:
|
guybedford
commented
Jun 10, 2023
Rather than expanding this section to every platform, it may be better at this point to reference the list at https://runtime-keys.proposal.wintercg.org/ directly here. |
Good point! Though I note that https://runtime-keys.proposal.wintercg.org/ doesn't include the "types" condition which the Node.js docs do. It also doesn't include "browser", "development" or "production". Maybe it would be best to keep only Node.js-ish stuff like this (below)?
note the lack of "deno" and "bun" |
guybedford
commented
Jun 10, 2023
That sounds sensible to me - now that these keys have a definition elsewhere, it would make sense to avoid duplication for them. |
I need to change my commit message because I read https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelinesafter making the tiny change 🤣
For reference on the "bun" export condition: https://bun.sh/docs/runtime/modules#resolution
