Uh oh!
There was an error while loading. Please reload this page.
Maintenance: Remove no longer relevant comments in debug-agent and crypto - #4843
Closed
Chris911 wants to merge 1 commit into
Closed
Maintenance: Remove no longer relevant comments in debug-agent and crypto#4843Chris911 wants to merge 1 commit into
Chris911 wants to merge 1 commit into
Conversation
Fishrock123
commented
Jan 24, 2016
Contributor
LGTM if they are good with it. @Chris911 Could you squash the commits and prefix the result with |
indutny
commented
Jan 24, 2016
Member
LGTM |
Chris911force-pushed
the
maintenace/comments-cleanup
branch
from
January 24, 2016 23:53
53949f9 to
1fa264aCompareChris911
commented
Jan 24, 2016
ContributorAuthor
@Fishrock123, done. |
jasnell
commented
Jan 27, 2016
Member
LGTM |
silverwind
commented
Feb 1, 2016
Contributor
Thanks! Landed in e20abb7. |
silverwind pushed a commit
that referenced
this pull request
Feb 1, 2016
PR-URL: #4843 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Chris911
commented
Feb 1, 2016
ContributorAuthor
👍. Looking forward to more important contributions. |
rvagg pushed a commit
that referenced
this pull request
Feb 8, 2016
PR-URL: #4843 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
that referenced
this pull request
Feb 17, 2016
PR-URL: #4843 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
that referenced
this pull request
Feb 18, 2016
PR-URL: #4843 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Mar 2, 2016
PR-URL: #4843 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4843 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced Oct 18, 2022
This was referenced Oct 18, 2022
This was referenced Oct 18, 2022
This was referenced Oct 19, 2022
This was referenced Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #4641
Trying to get my first PR up to get used to the contribution process. In #4641@indutny and @trevnorris mentioned their comments in node-agent and crypto were no longer relevant. This PR removes them.
Looking forward to more relevant contributions soon.
cc: @Fishrock123 (first contribution)