Skip to content

doc: fix typo in events.md - #48436

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RaisinTen:doc-fix-typo-in-events.md
Jun 12, 2023
Merged

doc: fix typo in events.md#48436
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RaisinTen:doc-fix-typo-in-events.md

Conversation

@RaisinTen

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTenRaisinTen added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 12, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @RaisinTen. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Jun 12, 2023
@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 12, 2023
@debadree25debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 4e0066e into nodejs:mainJun 12, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 4e0066e

@nodejs-github-botnodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jun 12, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48436
✔ Done loading data for nodejs/node/pull/48436
----------------------------------- PR info ------------------------------------
Title doc: fix typo in events.md (#48436)
Author Darshan Sen (@RaisinTen)
Branch RaisinTen:doc-fix-typo-in-events.md -> nodejs:main
Labels doc, events, fast-track, author ready
Commits 1
- doc: fix typo in events.md
Committers 1
- Darshan Sen PR-URL: https://github.com/nodejs/node/pull/48436
Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48436
Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
ℹ This PR was created on Mon, 12 Jun 2023 13:23:41 GMT
✔ Approvals: 3
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/48436#pullrequestreview-1474924898
✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48436#pullrequestreview-1475008547
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48436#pullrequestreview-1475298533
ℹ This PR is being fast-tracked
⚠ This PR was merged on Mon, 12 Jun 2023 16:15:04 GMT
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5246072814

@RaisinTen
RaisinTen deleted the doc-fix-typo-in-events.md branch June 12, 2023 16:29
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48436
✔ Done loading data for nodejs/node/pull/48436
----------------------------------- PR info ------------------------------------
Title doc: fix typo in events.md (#48436)
Author Darshan Sen (@RaisinTen)
Branch RaisinTen:doc-fix-typo-in-events.md -> nodejs:main
Labels doc, events, fast-track, author ready, commit-queue-failed
Commits 1
- doc: fix typo in events.md
Committers 1
- Darshan Sen PR-URL: https://github.com/nodejs/node/pull/48436
Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48436
Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
ℹ This PR was created on Mon, 12 Jun 2023 13:23:41 GMT
✔ Approvals: 3
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/48436#pullrequestreview-1474924898
✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48436#pullrequestreview-1475008547
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48436#pullrequestreview-1475298533
ℹ This PR is being fast-tracked
⚠ This PR was merged on Mon, 12 Jun 2023 16:15:04 GMT
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5246167439

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #48436
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#48436
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#48436
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 7, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #48436
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadornoruyadorno mentioned this pull request Sep 8, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #48436
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.docIssues and PRs related to the documentations.eventsIssues and PRs related to the events subsystem / EventEmitter.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@RaisinTen@nodejs-github-bot@lpinca@cjihrig@MoLow@debadree25