Skip to content

doc: refine when file is undefined in test events - #48451

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:adjust-file-docs
Jun 14, 2023
Merged

doc: refine when file is undefined in test events#48451
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:adjust-file-docs

Conversation

@MoLow

Copy link
Copy Markdown
Member

Follow-up for #48428 (comment)

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Jun 13, 2023
@MoLow
MoLow requested a review from benjamingrJune 13, 2023 18:39
Comment threaddoc/api/test.md Outdated
@MoLow
MoLowforce-pushed the adjust-file-docs branch from 9c15d15 to d4fd3a1CompareJune 14, 2023 08:10
@benjamingrbenjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 14, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 14, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 14, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 363eca1 into nodejs:mainJun 14, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 363eca1

@MoLow
MoLow deleted the adjust-file-docs branch June 14, 2023 15:12
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
PR-URL: #48451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 8, 2023
PR-URL: #48451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@ruyadornoruyadorno mentioned this pull request Sep 8, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
PR-URL: #48451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MoLow@nodejs-github-bot@benjamingr@lpinca@VoltrexKeyva