module: add SourceMap.lineLengths by isaacs · Pull Request #48461 · nodejs/node

isaacs · 2023-06-14T23:30:55Z

anonrig

Can you update the documentation as well?

isaacs · 2023-06-15T04:08:21Z

The failing tests in CI are a bit confusing, these all pass locally, and it looks like they're not running with source maps enabled for some reason. I'm not sure why anything I did there would have changed that though.

Fix: nodejs#48460

legendecas

LGTM % one nit.

legendecas · 2023-07-05T09:23:59Z

@@ -274,6 +274,7 @@ added:
 #### `new SourceMap(payload)`


The function signature should be updated to include the optional parameter too.
Suggested change
#### `new SourceMap(payload)`
#### `new SourceMap(payload[, lineLengths])`
As the generated code line lengths property is not part of the source maps spec, would it be more prudent to set the property with an option bag instead of a positional parameter?

would it be more prudent to set the property with an option bag instead of a positional parameter?
No strong opinions here, but it's a pita to change this kind of thing later, so I'm feeling like it's probably a good idea, too. Anyone else wanna weight on it?

@bcoe would you mind taking a look at this PR? Thank you!

Document lineLengths argument Make lineLengths part of an option bag rather than a positional arg

legendecas

LGTM

nodejs-github-bot · 2023-07-12T06:46:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52715/

nodejs-github-bot · 2023-07-12T15:00:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52737/

nodejs-github-bot · 2023-07-12T18:37:34Z

Landed in 9053943

Fix: #48460 PR-URL: #48461Fixes: #48460 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Fix: nodejs#48460 PR-URL: nodejs#48461Fixes: nodejs#48460 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

ruyadorno · 2023-09-12T01:17:39Z

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

targos · 2023-11-15T10:04:15Z

This is another PR that should have been labeled semver-minor.

PR-URL: #57098Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#57098Fixes: nodejs#57094 Refs: nodejs#48461 Refs: nodejs#47790 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #57098 Backport-PR-URL: #57129Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#57098Fixes: nodejs#57094 Refs: nodejs#48461 Refs: nodejs#47790 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #57098Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #57098 Backport-PR-URL: #57131Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #57098Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 14, 2023

anonrig reviewed Jun 15, 2023
View reviewed changes

isaacs force-pushed the isaacs/expose-source-maps-line-lengths branch from b2376cf to 5873274Compare June 15, 2023 04:04

isaacs force-pushed the isaacs/expose-source-maps-line-lengths branch from 5873274 to 11b3b96Compare June 15, 2023 16:50

isaacs force-pushed the isaacs/expose-source-maps-line-lengths branch from 11b3b96 to da4b63aCompare June 24, 2023 19:33

legendecas reviewed Jun 25, 2023
View reviewed changes

Comment threadlib/internal/source_map/source_map.js Outdated

module: add SourceMap.lineLengths
1485dc8
Fix: nodejs#48460

isaacs force-pushed the isaacs/expose-source-maps-line-lengths branch from da4b63a to 1485dc8Compare June 25, 2023 11:19

legendecas reviewed Jul 5, 2023
View reviewed changes

legendecas added the source maps Issues and PRs related to source map support. label Jul 5, 2023

fixup! module: add SourceMap.lineLengths
fed5a2f
Document lineLengths argument Make lineLengths part of an option bag rather than a positional arg

legendecas approved these changes Jul 12, 2023
View reviewed changes

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 12, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 12, 2023

lpinca added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 12, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2023

nodejs-github-bot merged commit 9053943 into nodejs:mainJul 12, 2023

juanarbol pushed a commit that referenced this pull request Jul 13, 2023
module: add SourceMap.lineLengths
6406f50
Fix: #48460 PR-URL: #48461Fixes: #48460 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

juanarbol mentioned this pull request Jul 13, 2023
V20.5.0 proposal #48761
Merged

This was referenced Jul 16, 2023
CI Reliability 2023-07-16 nodejs/reliability#614
Open
CI Reliability 2023-07-17 nodejs/reliability#615
Open

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
module: add SourceMap.lineLengths
2441f7a
Fix: nodejs#48460 PR-URL: nodejs#48461Fixes: nodejs#48460 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
module: add SourceMap.lineLengths
7e908d3
Fix: nodejs#48460 PR-URL: nodejs#48461Fixes: nodejs#48460 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

ruyadorno added the backport-requested-v18.x label Sep 12, 2023

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 15, 2023

aduh95 mentioned this pull request Feb 16, 2025
doc: fix link and history of SourceMap sections #57098
Merged

Navigation Menu

Uh oh!

Uh oh!

module: add SourceMap.lineLengths - #48461

module: add SourceMap.lineLengths#48461
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
isaacs:isaacs/expose-source-maps-line-lengths

isaacs commented Jun 14, 2023

Uh oh!

anonrig left a comment

Uh oh!

isaacs commented Jun 15, 2023

Uh oh!

Uh oh!

legendecas left a comment

Uh oh!

legendecasJul 5, 2023•
edited
Loading

Uh oh!

isaacsJul 11, 2023

Uh oh!

legendecasJul 12, 2023

Uh oh!

legendecas left a comment

Uh oh!

nodejs-github-bot commented Jul 12, 2023

Uh oh!

nodejs-github-bot commented Jul 12, 2023

Uh oh!

nodejs-github-bot commented Jul 12, 2023

Uh oh!

ruyadorno commented Sep 12, 2023

Uh oh!

targos commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	#### `new SourceMap(payload)`
	#### `new SourceMap(payload[, lineLengths])`

Uh oh!

Uh oh!

Conversation

isaacs commented Jun 14, 2023

Uh oh!

anonrig left a comment

Choose a reason for hiding this comment

Uh oh!

isaacs commented Jun 15, 2023

Uh oh!

Uh oh!

legendecas left a comment

Choose a reason for hiding this comment

Uh oh!

legendecasJul 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

isaacsJul 11, 2023

Choose a reason for hiding this comment

Uh oh!

legendecasJul 12, 2023

Choose a reason for hiding this comment

Uh oh!

legendecas left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jul 12, 2023

Uh oh!

nodejs-github-bot commented Jul 12, 2023

Uh oh!

nodejs-github-bot commented Jul 12, 2023

Uh oh!

ruyadorno commented Sep 12, 2023

Uh oh!

targos commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

legendecasJul 5, 2023•
edited
Loading